fix: Use URL-safe base64 encoding for X-Registry-Auth#941
Merged
achimnol merged 6 commits intoaio-libs:mainfrom Oct 31, 2025
Merged
fix: Use URL-safe base64 encoding for X-Registry-Auth#941achimnol merged 6 commits intoaio-libs:mainfrom
X-Registry-Auth#941achimnol merged 6 commits intoaio-libs:mainfrom
Conversation
X-Registry-Auth
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
+ Coverage 81.50% 81.57% +0.07%
==========================================
Files 24 24
Lines 1422 1422
Branches 190 190
==========================================
+ Hits 1159 1160 +1
Misses 186 186
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@asvetlov just bumping this in case you still want to review this fix. |
This aligns with how the Docker CLI encodes the same header.
for more information, see https://pre-commit.ci
achimnol
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Changes
utils.compose_auth_headerto usebase64.urlsafe_b64encodeon the returned string. This aligns with how the Docker CLI encodes the same header.I discovered this when an application using
aiodockerwas the only client not authenticating successfully against a private registry after a service user's password was rotated.Previously raised by me in #761.
Are there changes in behavior for the user?
Will allow authentication to succeed against private registries when the
X-Registry-Authrequire url-safe substitutions as decribed here: https://docs.python.org/3/library/base64.html#base64.urlsafe_b64encodeChecklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.