Use URL-safe base64 encoding for auth#761
Closed
robin-wayve wants to merge 3 commits intoaio-libs:masterfrom
robin-wayve:urlsafe-b64-auth
Closed
Use URL-safe base64 encoding for auth#761robin-wayve wants to merge 3 commits intoaio-libs:masterfrom robin-wayve:urlsafe-b64-auth
robin-wayve wants to merge 3 commits intoaio-libs:masterfrom
robin-wayve:urlsafe-b64-auth
Conversation
This aligns with how the Docker CLI encodes the same header.
robin-wayve
commented
Dec 8, 2022
|
|
||
| def test_compose_auth_header(): | ||
| auth = {"username": "alice", "password": "~"} | ||
| assert utils.compose_auth_header(auth) == "eyJ1c2VybmFtZSI6ICJhbGljZSIsICJwYXNzd29yZCI6ICJ-In0=" |
Author
There was a problem hiding this comment.
I don't know if I should make this more obvious somehow, but the - would be a + if this wasn't urlsafe_b64encode.
Author
|
@asvetlov do you have capacity to review / merge this? |
Author
|
This can be re-opened if desired. |
Contributor
Member
|
Yes, please |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Changes
compose_auth_headerto usebase64.urlsafe_b64encodeon the returned string. This aligns with how the Docker CLI encodes the same header.Are there changes in behavior for the user?
This allows authentication to private registries where the contents of the
authwould require substitutions as described here: https://docs.python.org/3/library/base64.html#base64.urlsafe_b64encodeRelated issue number
Not from this project, but I figured out that I was running into the same issue described here: moby/moby#41570
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.