Add timeout argument for docker.image.push() method#929
Merged
asvetlov merged 2 commits intoaio-libs:mainfrom Nov 20, 2024
Merged
Add timeout argument for docker.image.push() method#929asvetlov merged 2 commits intoaio-libs:mainfrom
asvetlov merged 2 commits intoaio-libs:mainfrom
Conversation
asvetlov
approved these changes
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 24 24
Lines 1434 1434
Branches 206 206
=======================================
Hits 1158 1158
Misses 184 184
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiodocker image pull already has a timeout argument, we need to introduce it for push method