Add tests indicating timeouts do not really work#64
Closed
Snawoot wants to merge 1 commit intoaio-libs:masterfrom
Snawoot:master
Closed
Add tests indicating timeouts do not really work#64Snawoot wants to merge 1 commit intoaio-libs:masterfrom Snawoot:master
Snawoot wants to merge 1 commit intoaio-libs:masterfrom
Snawoot:master
Conversation
Contributor
|
On your tests, what resolver are you using? |
Contributor
Author
|
@saghul In test, which I modified in this repo, non-existent resolver 1.2.3.4 is used. In test for application I develop I use local dnsmasq set to forward requests for specific domain to non-existent DNS server from reserved IP address space. In both cases timeout set for aiodns has no effect. Instead, I get error response after 4 seconds. |
Closed
|
Hey, this issue is always relevant today and there doesn't seems to be a way to correctly set a timeout. |
Contributor
|
I suspect the problem lies in pycares, but I never managed to get to the bottom of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR extends query timeout tests to ensure timeout has real influence on query duration. As you can see this test fails and outlines bug I actually met using aiodns. On my system query lasts 4 seconds instead of 0.1 secs and it seems to be timeout imposed by system (mine is Linux).
If needed, I can also open issue about this bug. My main question is: should I wait for fix or I should workaround this bug with something like
asyncio.wait_for?