Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (924b981) to head (97843d3).
Report is 1 commits behind head on master.

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   93.91%   93.85%   -0.07%     
==========================================
  Files           3        3              
  Lines         378      374       -4     
  Branches       29       29              
==========================================
- Hits          355      351       -4     
  Misses         14       14              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Just realized we don't test on 3.13

Let me fix that first

😱 no double quotes everywhere please

😱 no double quotes everywhere please

Looks to me like most of the code is already double quotes, so that'd just make it consistent across the codebase. Also easier to become compatible with formatters which all default to double quotes.

I reconfigured ruff to use single quotes

Yeah, that seems to be a lot more changes than double quotes. Would be preferable to me to follow the org-wide consensus of double quotes.

I'm not sure sure there's a concensus. I personally prefer the single ones 🤷‍♂️

Also, formatting YAML with indents like that will lead to synching complications.

Oh, and when formatting, I recommend separating linting fixes from style formatting as the latter could be added to blame ignore while the former shouldn't be hidden. In general, smaller changes are easier to review and agree on.

I'm pretty sure commitizen can be irritating too. Particularly, because it seems to enforce prefixed commit titles that are at odds with best practices (gitlint) and reinforce bad changelog hygiene..

I was integrating Ruff in a couple of places recently. I've found it useful to run the linter with --statistics manually at first. Then --select with --fix for a number of most common violations, committing each separately. Then, I only added it in linting mode (+config with linting and temporary suppressions). And finally I was adding the formatter but I wanted better trailing commas which sometimes canceled out Ruff. I've settled on a double-run of ruff with add-trailing-commas in-between and the outcome was rather good.

Here's what I ended up with on pre-existing codebases:

https://github.com/cherrypy/cheroot/blob/90a89b4/.pre-commit-config.yaml#L59-L89 / https://github.com/cherrypy/cheroot/blob/90a89b/.ruff.toml / https://github.com/cherrypy/cheroot/blob/90a89b4/.git-blame-ignore-revs#L12

https://github.com/ansible/awx-plugins/blob/21173c4/.pre-commit-config.yaml#L35-L63 / https://github.com/ansible/awx-plugins/blob/21173c4/.ruff.toml / https://github.com/ansible/awx-plugins/blob/21173c4/.git-blame-ignore-revs#L73

I trimmed down the config significantly and reverted the YAML changes.

I don't have strong preferences for the code formatting settings. As long as it's automated and I don't have to think about it, I'm good with whatever the group decides.

Could you separate pure formatting from everything else, though? This needs a separate PR so that we could get a commit hash for blame ignore. Just make sure it's only formatting and not linting fixes or anything else.

Also, the ruff entries should go first in the pre-commit config because other linters should check the changed versions of files after they've been formatted.

formatting moved to #155

This is a good start. We can expand this later