Skip to content

feat: add state type name getter to python bindings#249

Merged
bpapaspyros merged 1 commit into
mainfrom
feat/state-type-name-python-binding
Jul 3, 2025
Merged

feat: add state type name getter to python bindings#249
bpapaspyros merged 1 commit into
mainfrom
feat/state-type-name-python-binding

Conversation

@bpapaspyros

Copy link
Copy Markdown

Description

This PR solves the issue by binding the existing C++ function

Review guidelines

Estimated Time of Review: 1 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@bpapaspyros bpapaspyros requested a review from domire8 July 3, 2025 09:40
@bpapaspyros bpapaspyros self-assigned this Jul 3, 2025
@bpapaspyros bpapaspyros linked an issue Jul 3, 2025 that may be closed by this pull request
@bpapaspyros

Copy link
Copy Markdown
Author

we don't actually have tests for these functions (but they are pretty straightforward). I could also add some, what do you think @domire8

@domire8 domire8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay, not all the parts in python are covered by tests but for a function like this is not worth getting into it apart from maybe quickly testing it in a python shell. Thanks!

@bpapaspyros

Copy link
Copy Markdown
Author

It's okay, not all the parts in python are covered by tests but for a function like this is not worth getting into it apart from maybe quickly testing it in a python shell. Thanks!

yup, already tested locally and works

@bpapaspyros bpapaspyros merged commit a4596fe into main Jul 3, 2025
5 checks passed
@bpapaspyros bpapaspyros deleted the feat/state-type-name-python-binding branch July 3, 2025 10:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get state type name is not available in Python

2 participants