Replace scheduler backend global mutable state with well defined interface and dependency injection#512
Merged
Merged
Conversation
09bf247 to
8ba470e
Compare
unmarshall
previously approved these changes
Apr 10, 2026
37469b0 to
fcdac8f
Compare
fcdac8f to
b870092
Compare
b870092 to
220debf
Compare
unmarshall
previously approved these changes
May 8, 2026
220debf to
ac77c50
Compare
unmarshall
previously approved these changes
May 9, 2026
a98d758 to
81bae34
Compare
unmarshall
approved these changes
May 12, 2026
a92a1c9 to
5f31516
Compare
sanjaychatterjee
approved these changes
May 13, 2026
5f31516 to
36314c4
Compare
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
* Removed nil pointer checks in the scheduler registry code. * Introduced FakeSchedulerBackend to be used in unit tests. * Minor changes in scheduler registry implementation. * Fixed tests after nil pointer checks were removed. Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
… backoff and reduce RU flakiness Signed-off-by: Kang Zhang <kangz@nvidia.com>
Signed-off-by: Kang Zhang <kangz@nvidia.com>
…e errors and unify with ERR_REQUEUE_AFTER Signed-off-by: Kang Zhang <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: Kang Zhang <kangz@nvidia.com>
* Added GetOrDefault and AllTopologyAware to scheduler.Registry type. * changed clustertopology controller to now use tas enabled backends only. Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: Kang Zhang <kangz@nvidia.com>
36314c4 to
1213809
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Refactor: Replace Scheduler Backend Global State with Dependency Injection
Which issue(s) this PR fixes:
Fixes #509
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: