Add crd upgrade readme file#495
Conversation
shayasoolin
left a comment
There was a problem hiding this comment.
LGTM. Reminder for the implementation stage: remember to apply any tolerations that are provided for the controller, also to the hook job.
shayasoolin
left a comment
There was a problem hiding this comment.
Note that Dynamo is using a separate helm chart for CRDs: dynamo-crds.
I considered it, but this solution has a hard dependency on the user - if he forgets to install the CRD's, it can cause a bad and unknown behavior. |
They might have changed it in their last versions, I just installed v1.0.1 using Helm and I don't see that separate chart again... |
@danbar2 @shayasoolin |
* Add crd upgrade readme file * Refine the readme file * update toc * skip ci steps gracefully * skip ci steps gracefully * init container approach * allow crd installer opt out Signed-off-by: Erez Freiberger <enoodle@gmail.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Completes #436
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: