replace test image to busybox#476
Merged
Merged
Conversation
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
shayasoolin
previously approved these changes
Mar 8, 2026
Ronkahn21
previously approved these changes
Mar 8, 2026
renormalize
previously approved these changes
Mar 9, 2026
526f671
Signed-off-by: kangclzjc <kangz@nvidia.com>
526f671 to
13bef36
Compare
Signed-off-by: kangclzjc <kangz@nvidia.com>
Contributor
Author
|
nginx:alpine-slim exits gracefully. busybox with sleep infinity should exit in theory, but when running as PID 1 or with different signal handling, it may result in slow or unreliable termination. We add |
Ronkahn21
approved these changes
Mar 9, 2026
sanjaychatterjee
approved these changes
Mar 10, 2026
Ronkahn21
pushed a commit
to Ronkahn21/grove
that referenced
this pull request
Mar 10, 2026
* replace test image to busybox Signed-off-by: kangclzjc <kangz@nvidia.com> * add command parameters for creating pclq Signed-off-by: kangclzjc <kangz@nvidia.com> * add terminationGracePeriodSeconds Signed-off-by: kangclzjc <kangz@nvidia.com> * add back PatchSIGTERM Signed-off-by: kangclzjc <kangz@nvidia.com> --------- Signed-off-by: kangclzjc <kangz@nvidia.com>
enoodle
pushed a commit
to enoodle/grove
that referenced
this pull request
Mar 24, 2026
* replace test image to busybox Signed-off-by: kangclzjc <kangz@nvidia.com> * add command parameters for creating pclq Signed-off-by: kangclzjc <kangz@nvidia.com> * add terminationGracePeriodSeconds Signed-off-by: kangclzjc <kangz@nvidia.com> * add back PatchSIGTERM Signed-off-by: kangclzjc <kangz@nvidia.com> --------- Signed-off-by: kangclzjc <kangz@nvidia.com> Signed-off-by: Erez Freiberger <enoodle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In some e2e tests, container could be killed because OOM. And after tracking that in some of our test, we use alpine-slim, and no start command in workload yaml. Because default this image will create many number of nginx workers based on the CPU cores of the node. In my L20 machine, it will create nearly 130 nginx worker for each test pod. The pod will keep crash and the node always become Unready. In our CI/CD e2e test, I also see the same failure.
Which issue(s) this PR fixes:
Fixes #475
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: