fix: add podCliqueScalingGroup concurrentSyncs to Helm chart#472
Merged
Conversation
Fixes ai-dynamo#471 Signed-off-by: Ron Kahn <rkahn@nvidia.com>
shayasoolin
approved these changes
Mar 5, 2026
sanjaychatterjee
approved these changes
Mar 5, 2026
Ronkahn21
added a commit
to Ronkahn21/grove
that referenced
this pull request
Mar 10, 2026
…mo#472) Fixes ai-dynamo#471 Signed-off-by: Ron Kahn <rkahn@nvidia.com>
enoodle
pushed a commit
to enoodle/grove
that referenced
this pull request
Mar 24, 2026
…mo#472) Fixes ai-dynamo#471 Signed-off-by: Ron Kahn <rkahn@nvidia.com> Signed-off-by: Erez Freiberger <enoodle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The Helm chart template (
_helpers.tpl) andvalues.yamlonly configureconcurrentSyncsforpodCliqueSetandpodCliquecontrollers, but omitpodCliqueScalingGroup. The PCSG controller supports this config field, so it should be rendered in the Helm chart.This PR adds
podCliqueScalingGroup.concurrentSyncsto both_helpers.tplandvalues.yaml(default: 3, matching the other controllers).Which issue(s) this PR fixes:
Fixes #471
Special notes for your reviewer:
NONE
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: