feat: add configurable pprof bind address#464
Merged
Conversation
Add pprofBindAddress field to operator config to allow customizing the pprof server's bind address. Update Helm charts to expose pprof as a service and add API docs. Part of ai-dynamo#402 Signed-off-by: Ron Kahn <rkahn@nvidia.com>
46b7a4f to
7c0e9db
Compare
renormalize
reviewed
Mar 5, 2026
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @Ronkahn21! Just a couple comments~
Split the single pprofBindAddress string field into separate pprofBindHost and pprofBindPort fields to properly support IPv6 addresses via net.JoinHostPort. Use ptr.Deref for cleaner nil checks. Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Update API documentation to reflect the separation of pprofBindAddress into pprofBindHost and pprofBindPort fields, improving support for IPv6 and external scraping configurations. Signed-off-by: Ron Kahn <rkahn@nvidia.com>
renormalize
previously approved these changes
Mar 6, 2026
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Added a few nits. We can merge this after they're addressed. Thanks.
gflarity
reviewed
Mar 6, 2026
gflarity
left a comment
Contributor
There was a problem hiding this comment.
One small thing, otherwise LGTM.
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
gflarity
previously approved these changes
Mar 6, 2026
Defaulters guarantee PprofBindHost and PprofBindPort are always set, so remove redundant nil checks and ptr.Deref calls. Make DefaultPprofBindPort private since it's no longer used externally. Signed-off-by: Ron Kahn <rkahn@nvidia.com>
489a49a to
c6b8f8d
Compare
shayasoolin
previously approved these changes
Mar 8, 2026
shmuel-runai
reviewed
Mar 8, 2026
shmuel-runai
reviewed
Mar 8, 2026
renormalize
approved these changes
Mar 9, 2026
shayasoolin
approved these changes
Mar 9, 2026
Ronkahn21
added a commit
to Ronkahn21/grove
that referenced
this pull request
Mar 10, 2026
enoodle
pushed a commit
to enoodle/grove
that referenced
this pull request
Mar 24, 2026
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a configurable
pprofBindAddressto the operator config and Helm chart, enabling pprof profiling for scale testing. Also adds a genericannotationsfield to the Helm chart pod template to support auto-scrape by profiling systems, and a pprof service port with a Helm helper for port extraction.Which issue(s) this PR fixes:
Fixes #402
Special notes for your reviewer:
This is PR 1 of 3 for the scale testing infrastructure. PR 2 (#465) adds the infra-manager CLI with Pyroscope annotation injection, and a follow-up PR will migrate the e2e workflow to use the new CLI.
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: