Record Delete in CreateExpectation#458
Merged
Merged
Conversation
unmarshall
requested changes
Mar 2, 2026
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
…or Pod watch Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
unmarshall
approved these changes
Mar 3, 2026
sanjaychatterjee
approved these changes
Mar 3, 2026
Ronkahn21
pushed a commit
to Ronkahn21/grove
that referenced
this pull request
Mar 10, 2026
Fixes issue by clearing unfulfilled create expectations upon observing a delete event. --------- Signed-off-by: kangclzjc <kangz@nvidia.com> Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com> Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
enoodle
pushed a commit
to enoodle/grove
that referenced
this pull request
Mar 24, 2026
Fixes issue by clearing unfulfilled create expectations upon observing a delete event. --------- Signed-off-by: kangclzjc <kangz@nvidia.com> Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com> Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com> Signed-off-by: Erez Freiberger <enoodle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We couldn't tell these two scenarios:
So in some case, deleted pod(manually by kubectl delete) can't be re-created again.
Which issue(s) this PR fixes:
Fixes #457
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: