[e2e] [mnnvl] resolve flaky e2e test in Config2_UnsupportedButEnabled#451
Merged
sanjaychatterjee merged 2 commits intoMar 3, 2026
Merged
Conversation
During a rolling deployment (maxUnavailable=0, maxSurge=1), both the old healthy operator pod and the new crashing pod coexist. The old pod may have RestartCount > 0 from cert-refresh restarts, causing waitForOperatorPod to non-deterministically select it instead of the actually-crashing pod. Rename waitForOperatorPod to waitForFailedOperatorPod and filter out Ready pods so only the crashing pod (which never becomes Ready) is selected.
shayasoolin
previously approved these changes
Feb 25, 2026
shayasoolin
approved these changes
Mar 2, 2026
sanjaychatterjee
approved these changes
Mar 3, 2026
Ronkahn21
pushed a commit
to Ronkahn21/grove
that referenced
this pull request
Mar 10, 2026
…ai-dynamo#451) * [e2e] [mnnvl] resolve flaky e2e test in Config2_UnsupportedButEnabled During a rolling deployment (maxUnavailable=0, maxSurge=1), both the old healthy operator pod and the new crashing pod coexist. The old pod may have RestartCount > 0 from cert-refresh restarts, causing waitForOperatorPod to non-deterministically select it instead of the actually-crashing pod. Rename waitForOperatorPod to waitForFailedOperatorPod and filter out Ready pods so only the crashing pod (which never becomes Ready) is selected. * add computedomain to groveManagedResourceTypes
enoodle
pushed a commit
to enoodle/grove
that referenced
this pull request
Mar 24, 2026
…ai-dynamo#451) * [e2e] [mnnvl] resolve flaky e2e test in Config2_UnsupportedButEnabled During a rolling deployment (maxUnavailable=0, maxSurge=1), both the old healthy operator pod and the new crashing pod coexist. The old pod may have RestartCount > 0 from cert-refresh restarts, causing waitForOperatorPod to non-deterministically select it instead of the actually-crashing pod. Rename waitForOperatorPod to waitForFailedOperatorPod and filter out Ready pods so only the crashing pod (which never becomes Ready) is selected. * add computedomain to groveManagedResourceTypes Signed-off-by: Erez Freiberger <enoodle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
During a rolling deployment (maxUnavailable=0, maxSurge=1), both the old healthy operator pod and the new crashing pod coexist. The old pod may have RestartCount > 0 from cert-refresh restarts, causing waitForOperatorPod to non-deterministically select it instead of the actually-crashing pod.
Rename waitForOperatorPod to waitForFailedOperatorPod and filter out Ready pods so only the crashing pod (which never becomes Ready) is selected.
Which issue(s) this PR fixes:
Fixes #449
Special notes for your reviewer: