fixed the owner name to be lower case nvidia#222
Merged
Conversation
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
sanjaychatterjee
approved these changes
Oct 20, 2025
renormalize
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
#219 introduced a bug where it tries to generalize the repo name which is used as part of
DOCKER_REGISTRY: "ghcr.io/${{ github.repository_owner }}/grove"The issue is that for the current org
NVIDIAthis is all upper case. This does not work for docker registry urls. It must be lower case. For now this PR only reverts this change and hard codes it toNVIDIAbut we need to test a generic fix which also lower cases it.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: