document internal/logger and internal/utils#208
Merged
gflarity merged 2 commits intoOct 22, 2025
Merged
Conversation
2c5f050 to
5280cd6
Compare
Ronkahn21
previously approved these changes
Oct 16, 2025
renormalize
previously approved these changes
Oct 21, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
There seems to be a few common comments in #211 and this PR. Just a heads-up since you might get conflicts in the other after merging one!
Thanks for the PR!
5280cd6 to
4e19ea0
Compare
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
4e19ea0 to
a5af555
Compare
sanjaychatterjee
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/documentation
What this PR does / why we need it:
Improves documentation the in internal/logger and internal/utils folders. Similar the documentation side of #204
Special notes for your reviewer:
Here's the prompt used:
Please create an idiomatic golang unit tests for this specific directory/package. Herea are the instructions:
Does this PR introduce a API change?