Add unit-tests for initc and improve in-line doc strings#204
Merged
Conversation
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
314bf01 to
873a07c
Compare
renormalize
previously approved these changes
Sep 26, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @gflarity!
I've added a test case for replica count as an empty string, and one for white space around the colon.
I've also renamed 2 generated test functions to follow Go conventions.
…tions in `wait_test.go`. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>
dcf120b to
b295ffa
Compare
renormalize
previously approved these changes
Sep 26, 2025
Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>
unmarshall
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
/kind tests
What this PR does / why we need it:
This PR is follow up to #193
It improves to documentation and tests for the initc directory. The prompt has been updated to avoid obvious/non-valuable comments and avoid duplication. Updated documentation prompt below. Please feel free to make suggestions to the prompt. Note the goal isn't to be perfect, just practical and useful.
I also fixed the bugs highlighted in the PR as the result of tests.
Special notes for your reviewer:
Documentation Prompt:
Test Prompt:
Does this PR introduce a API change?
NONE