Modify PodCliqueScalingGroup behavior to create new PodCliques for each replica#103
Merged
Merged
Conversation
reconcilers. This commit includes: * Introduces a finalizer for PCSG resources. This will be used for ensuring that all PCLQs that it manages are cleaned up before this resource gets deleted. * Renamed the component directories to have a consistent naming. * Modified Operator.Delete to now take metav1.ObjectMeta instead of the object. * PCSG reconciler now listens for PGS update events. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Fixed PCLQ component in PCSG. It is still a WIP and needs additional corrections. * Now getting the PGS name from the label as opposed to OwnerRef because PCLQ can either have PGS or PCSG as owner. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
PCSG * Introduced RoleName in PodCliqueTemplateSpec Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
…gGroup. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
reconciler. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
* Updated simple1.yaml to now have role names for each PodClique. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
renormalize
approved these changes
Jul 9, 2025
renormalize
added a commit
that referenced
this pull request
Jul 15, 2025
* New `PodClique`s are created for each replica of the `PodCliqueScalingGroup` as a consequence of #103. This is corrected in the example now. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
RoleNameinPodCliqueSpec, generated code and api-docs to reflect that.