feat: Add estimated kv cache hit metric events#30
Merged
Conversation
Contributor
Test Results 2 files 2 suites 54s ⏱️ Results for commit f2dcb27. ♻️ This comment has been updated with latest results. |
…_cache_hit/events
… count and log estimated cumulative hit rate
…na dashboard - sizement/placing is off though
…_cache_hit/events
…/dynemo into rmccormick/kv_cache_hit/events
grahamking
reviewed
Mar 6, 2025
grahamking
reviewed
Mar 6, 2025
grahamking
reviewed
Mar 6, 2025
grahamking
reviewed
Mar 6, 2025
grahamking
approved these changes
Mar 6, 2025
This was referenced Mar 6, 2025
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Adds per-worker and cumulative estimated kv cache hit metrics (ISL blocks / Overlapping blocks) in Grafana.
Details:
Changes:
EventSubscribertrait and implements it forNamespaceFuture Work:
Example Grafana Dashboard with new timeseries panels and gauge for Per-worker and Cumulative KV Cache Hit Rate estimation: