Skip to content

refactor: rename triton_distributed to dynemo for libraries#22

Merged
nnshah1 merged 17 commits into
mainfrom
nnshah1-rename-library
Mar 5, 2025
Merged

refactor: rename triton_distributed to dynemo for libraries#22
nnshah1 merged 17 commits into
mainfrom
nnshah1-rename-library

Conversation

@nnshah1

@nnshah1 nnshah1 commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Overview:

Rename libraries to dynemo

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Comment thread .dockerignore Outdated
Comment thread deploy/compoundai/sdk/src/compoundai/cli/serve_nova.py Outdated
Comment thread deploy/compoundai/sdk/src/compoundai/sdk/dependency.py Outdated
@github-actions

github-actions Bot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Test Results

  2 files    2 suites   53s ⏱️
 80 tests  79 ✅ 1 💤 0 ❌
102 runs  100 ✅ 2 💤 0 ❌

Results for commit 37bb7be.

♻️ This comment has been updated with latest results.

@nnshah1

nnshah1 commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

CONTRIBUTING.md is filled with references to Triton. Are we waiting for legal on that?

This is just the first of several PRs. It does the directory renames and most of the big code changes, but there will be others right after. This is the most likely to merge conflict with, well, everything, so trying to get it in early.

Agree - want to try to get to incremental pieces - docs and non code pieces to come in later (enviornment variables, default namespace)

@rmccorm4 rmccorm4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit for follow-up, I think a bunch of "triton-distributed" got changed to "dynemo-distributed" instead of "dynemo", but looks like mostly comments

@nnshah1 nnshah1 merged commit 13ab5de into main Mar 5, 2025
@nnshah1 nnshah1 deleted the nnshah1-rename-library branch March 5, 2025 17:15
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
Co-authored-by: Graham King <grahamk@nvidia.com>
kangclzjc added a commit to kangclzjc/dynamo that referenced this pull request Jun 4, 2026
…oder reuse, doc fixes

Low-risk cleanup batch from the independent review (no decision-path change):

- ai-dynamo#4 chain_augment: add ``predicted_kv_hit_rate`` to ``_PREDICTION_FIELDS``
  so it participates in first-writer-wins partial merge like the other three
  predicted_* fields (was silently dropped in any 2+ plugin PREDICT chain,
  contradicting the proto/Pydantic contract). +2 chain_augment tests.
- #10 engine_adapter: add ``scale_down_capped_by_throughput`` to
  ``_aggregate_disagg_load_reason`` priority (PSM disagg emits it; placed
  between scale_up and scale_down to mirror PSM's _PRIORITY).
- ai-dynamo#11 dead code: drop ``contributing_plugin_ids`` (built, never read) in
  pipeline._run_fanout_stage; drop ``_set_enabled`` + ``_plugin_ids``
  (no caller in PR #1; would KeyError if reached).
- ai-dynamo#18 _encode_fpm: use the canonical
  ``dynamo.common.forward_pass_metrics.encode`` (shared module-level encoder)
  instead of allocating a fresh ``msgspec.msgpack.Encoder`` per tick and
  re-implementing the encoding. Byte-identical wire format; keeps FPM
  serialization in lock-step with the rest of dynamo.
- ai-dynamo#17 transport ABC docstring: timeout is enforced by the transport
  (``call()`` wraps ``asyncio.wait_for``), not the orchestrator — the
  pipeline uses a bare gather to avoid double-counting the deadline.
- ai-dynamo#20 scheduler docstring: note the heartbeat-eviction monitor is not wired
  in this PR (last_heartbeat_at is recorded but unread; monitor is follow-up).
- ai-dynamo#21 transport contract test: 7 inputs (not 8) → 14 cases (multi_pool fixture
  was removed with component_name; comments were stale).
- ai-dynamo#22 metrics test: remove the dead no-op ``pass`` loop in _sample_value.

828 planner tests pass (was 825; +3 chain-augment / merge tests).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants