Skip to content

ci: Add python "pre-merge" tests when merging to main#19

Merged
saturley-hall merged 1 commit into
mainfrom
harrison/add_pre-merge_checks_on_merge_to_main
Mar 5, 2025
Merged

ci: Add python "pre-merge" tests when merging to main#19
saturley-hall merged 1 commit into
mainfrom
harrison/add_pre-merge_checks_on_merge_to_main

Conversation

@saturley-hall

Copy link
Copy Markdown
Member

Overview:

Gives Action runs of main parity with the PR python pre-merge pytests.

Details:

Rename the GitHub workflow file for clarity.

Added in Pytests equivalent to what is done in our internal repo and on PRs.

Archive the test report for analysis

Where should the reviewer start?

.github/workflows/main_validation.yaml

@github-actions

github-actions Bot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Test Results

 2 files   2 suites   52s ⏱️
77 tests 77 ✅ 0 💤 0 ❌
99 runs  98 ✅ 1 💤 0 ❌

Results for commit 876f5d7.

@pvijayakrish pvijayakrish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
nit: Do we want to rename the yaml file?

@saturley-hall saturley-hall changed the title CI: Add python "pre-merge" tests when merging to main ci: Add python "pre-merge" tests when merging to main Mar 5, 2025
@saturley-hall saturley-hall marked this pull request as ready for review March 5, 2025 13:46
@saturley-hall saturley-hall requested a review from nnshah1 as a code owner March 5, 2025 13:46
@saturley-hall saturley-hall requested a review from a team March 5, 2025 13:46
@saturley-hall

Copy link
Copy Markdown
Member Author

LGTM! nit: Do we want to rename the yaml file?

Just to be more clear that it is doing more than caching the main branch now, yes. Note that we are also changing the name of the Workflow.

@saturley-hall saturley-hall merged commit 968ca0b into main Mar 5, 2025
@saturley-hall saturley-hall deleted the harrison/add_pre-merge_checks_on_merge_to_main branch March 5, 2025 13:48
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
kangclzjc added a commit to kangclzjc/dynamo that referenced this pull request Jun 4, 2026
…auge reset (review ai-dynamo#12/ai-dynamo#13/ai-dynamo#19)

Hot-path quality fixes — none change a scaling decision.

ai-dynamo#12 pipeline durations use Clock.monotonic(), not Clock.now()
  Clock's contract reserves now() for wall-clock timestamps and monotonic()
  for duration measurement. Six duration sites (predict latency, fan-out
  call latency, whole-tick duration) used now(); under WallClock a backward
  NTP step mid-tick distorted the latency/duration histograms. Switched all
  six to monotonic(). VirtualClock.monotonic() is synced to trace time in
  replay, so replay/test behavior is unchanged.

ai-dynamo#13 ProposeResult derives result_kind + enforces the oneof
  ProposeResult carries the same accept/override/reject oneof as the stage
  responses but, unlike them, had no model_post_init — so building it the
  natural way (override=...) left result_kind='' and the proto round-trip
  came back 'override', breaking round-trip equality; a two-payload oneof
  violation also went unchecked. Extracted the derive+validate logic into a
  shared _derive_result_kind() helper used by both _StageOneofResponse and
  ProposeResult. +round-trip test (derive + oneof-violation reject).

ai-dynamo#19 override_active gauge reset covers errored plugins
  _emit_override_active reset the gauge only for plugins in plugin_results;
  a plugin whose call raised is absent from that list, so a 1 it set on a
  prior tick lingered. Now reset every ATTEMPTED plugin id (triggered +
  inherited) before setting the contributors.

828 planner tests pass (+1 round-trip test).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants