test: fix flaky allocation metrics test server startup by srpvpn · Pull Request #4445 · agones-dev/agones

srpvpn · 2026-02-11T22:03:24Z

Title
test: fix flaky TestAllocationMetrics port conflict and startup race

Changes:

Removed hardcoded metrics port (3001) from the test path.
Added dynamic test server bootstrap using a pre-bound ephemeral listener (127.0.0.1:0).
Replaced fixed time.Sleep(300ms) with readiness polling against the metrics endpoint.
Added TestStartMetricsServer to validate server bootstrap helper behavior.

google-cla · 2026-02-11T22:03:29Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

markmandel

Thanks for tacking this!

markmandel · 2026-02-12T04:26:33Z

pkg/gameserverallocations/metrics_test.go

-		_ = server.Run(ctxHTTP, 0)
-	}()
-	time.Sleep(300 * time.Millisecond)
+	err = wait.PollUntilContextTimeout(context.Background(), 10*time.Millisecond, 5*time.Second, true, func(_ context.Context) (bool, error) {


We're moving to using https://pkg.go.dev/github.com/stretchr/testify/require#EventuallyWithT for polling tests -- it gives a much better developer surface and also error messages.

Thanks, I did it.

markmandel · 2026-02-12T04:27:46Z

/gcbrun

agones-bot · 2026-02-12T05:24:34Z

Build Succeeded 🥳

Build Id: 0cd6d6ce-0486-402b-9eee-c8e4d73d0783

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-0350016
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-0350016
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-0350016-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-0350016
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-0350016
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-0350016
Linux C++ SDK (build): agonessdk-1.56.0-dev-0350016-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-0350016.zip

A preview of the website (the last 30 builds are retained):

https://0350016-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4445/head:pr_4445 && git checkout pr_4445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-0350016

markmandel

Thanks for tackling this! Almost there.

markmandel · 2026-02-13T02:31:05Z

pkg/gameserverallocations/metrics_test.go

+
+	metricsURL := startMetricsServerForTest(t, server)
+
+	err := wait.PollUntilContextTimeout(context.Background(), 10*time.Millisecond, time.Second, true, func(_ context.Context) (bool, error) {


Same thing as well here please - EventuallyWithT.

Also means that if assert.NoError(t, resp.Body.Close()) fails for some reason it will get reported appropriately.

Ok, thanks, I did that too

markmandel · 2026-02-13T03:44:39Z

/gcbrun

agones-bot · 2026-02-13T04:45:53Z

Build Succeeded 🥳

Build Id: 770e853b-be34-49ae-930f-42b0cde024bc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-a0ef9eb
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-a0ef9eb
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-a0ef9eb-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-a0ef9eb
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-a0ef9eb
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-a0ef9eb
Linux C++ SDK (build): agonessdk-1.56.0-dev-a0ef9eb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-a0ef9eb.zip

A preview of the website (the last 30 builds are retained):

https://a0ef9eb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4445/head:pr_4445 && git checkout pr_4445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-a0ef9eb

markmandel

Thanks!

markmandel · 2026-02-13T21:18:53Z

/gcbrun

agones-bot · 2026-02-13T22:20:22Z

Build Succeeded 🥳

Build Id: 49acc863-e448-4988-9ee8-17bff6ffca22

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-e0372ce
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-e0372ce
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-e0372ce-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-e0372ce
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-e0372ce
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-e0372ce
Linux C++ SDK (build): agonessdk-1.56.0-dev-e0372ce-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-e0372ce.zip

A preview of the website (the last 30 builds are retained):

https://e0372ce-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4445/head:pr_4445 && git checkout pr_4445
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-e0372ce

* test: fix flaky allocation metrics test server startup * test: use EventuallyWithT for metrics readiness poll * test: use EventuallyWithT in start metrics server test --------- Co-authored-by: srpvpn <srpvpn@users.noreply.github.com>

test: fix flaky allocation metrics test server startup

0350016

github-actions bot added kind/other size/S labels Feb 11, 2026

markmandel reviewed Feb 12, 2026

View reviewed changes

test: use EventuallyWithT for metrics readiness poll

a0ef9eb

markmandel reviewed Feb 13, 2026

View reviewed changes

test: use EventuallyWithT in start metrics server test

e0372ce

markmandel approved these changes Feb 13, 2026

View reviewed changes

markmandel enabled auto-merge (squash) February 13, 2026 21:18

markmandel merged commit b9bbac2 into agones-dev:main Feb 13, 2026
5 checks passed


		metricsURL := startMetricsServerForTest(t, server)

		err := wait.PollUntilContextTimeout(context.Background(), 10*time.Millisecond, time.Second, true, func(_ context.Context) (bool, error) {

Conversation

srpvpn commented Feb 11, 2026

Uh oh!

google-cla bot commented Feb 11, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

srpvpn Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel commented Feb 12, 2026

Uh oh!

agones-bot commented Feb 12, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

srpvpn Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel commented Feb 13, 2026

Uh oh!

agones-bot commented Feb 13, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel commented Feb 13, 2026

Uh oh!

agones-bot commented Feb 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants