Added dark mode to the website by thegalacticlor · Pull Request #4439 · agones-dev/agones

thegalacticlor · 2026-02-08T21:55:51Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:
This adds a dark mode to the website by adding a toggle in the nav bar based on Docsy's. This also makes theme consistent across all pages, fixing certain colors and overwritten variables.

Which issue(s) this PR fixes:

Closes #4429

Special notes for your reviewer:
All files created were made so I could properly override the variables already set.

…ixed areas where the teme didnt apply properly.

markmandel

Ooh, exciting. Looking forward to seeing the preview.

/gcbrun

markmandel · 2026-02-08T22:03:32Z

site/assets/scss/_darkmode-overrides.scss

@@ -0,0 +1,27 @@
+/* Dark mode overrides for the custom Agones navbar and UI */


Apache licence please 👍🏻

markmandel · 2026-02-08T22:03:45Z

site/assets/scss/_styles_project.scss

@@ -0,0 +1 @@
+@import "darkmode-overrides";


Apache licence please.

markmandel · 2026-02-08T22:05:33Z

/gcbrun

agones-bot · 2026-02-08T22:45:35Z

Build Failed 😭

Build Id: 3493ae89-c28b-4476-aeb8-79dbe6cd305c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2026-02-09T05:30:44Z

TestGameServerAllocationReturnLabels being flaky again.

/gcbrun

agones-bot · 2026-02-09T06:22:59Z

Build Succeeded 🥳

Build Id: a9a9fdbf-8c33-4357-9438-e5e557d329b1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-2e27321
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-2e27321
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-2e27321-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-2e27321
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-2e27321
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-2e27321
Linux C++ SDK (build): agonessdk-1.56.0-dev-2e27321-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-2e27321.zip

A preview of the website (the last 30 builds are retained):

https://2e27321-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4439/head:pr_4439 && git checkout pr_4439
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-2e27321

markmandel · 2026-02-09T20:07:12Z

This is nice!

Just looking for a second pair of eyes -- @lacroixthomas do we care that the dark mode for the landing page is just the header?

I'm thinking we don't actually care - flipping the entire home landing page seems like a lot of work, and not really worth it.

What do you think @thegalacticlor ? Did you look at the _index.html, or also figured it was too much work 😄

thegalacticlor · 2026-02-09T22:58:19Z

I didn't want to change the set colors for both that and the community page since they already feature a combination of both color palettes already, so I just focused mostly on making sure it was consistent :D

markmandel · 2026-02-09T23:07:25Z

Sounds reasonable to me! We will need the Apache licences at the top of the files please before we can accept the PR. But otherwise this looks good to me.

lacroixthomas · 2026-02-10T22:29:51Z

That's pretty nice !! I'll definitively use it hehe
I agree, there is the landing page and the community page that are quite "white", but I think it's good like that - if people are complaining we can create an issue for it, but as it is right now it's already great !

Other than the Apache Licenses, looks good to me 👌🏼

markmandel · 2026-02-11T01:09:04Z

@thegalacticlor if you get a moment to update the Apache licence, that would be awesome. I want to merge #4438 after this, but want to make sure any conflicts fall on my shoulders rather than yours 👍🏻

…thegalacticlor/agones into Adding-Dark-Mode-to-the-Website

thegalacticlor · 2026-02-11T04:30:15Z

Just added the Apache licenses!

Sivasankaran25 · 2026-02-11T05:25:41Z

/gcbrun

site/assets/scss/_darkmode-overrides.scss

site/assets/scss/_styles_project.scss

agones-bot · 2026-02-11T06:21:36Z

Build Succeeded 🥳

Build Id: 6fd2aa00-83ce-43b0-9c6e-461f635363bd

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-64d752e
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-64d752e
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-64d752e-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-64d752e
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-64d752e
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-64d752e
Linux C++ SDK (build): agonessdk-1.56.0-dev-64d752e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-64d752e.zip

A preview of the website (the last 30 builds are retained):

https://64d752e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4439/head:pr_4439 && git checkout pr_4439
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-64d752e

Co-authored-by: Mark Mandel <mark@compoundtheory.com>

thegalacticlor · 2026-02-11T14:31:44Z

Fixed!

markmandel

Let's get dark.

/gcbrun

markmandel · 2026-02-11T17:58:10Z

/gcbrun

agones-bot · 2026-02-11T18:10:47Z

Build Failed 😭

Build Id: 4704c5a8-7a2a-452c-82b8-9676ddae0327

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2026-02-11T18:13:16Z

flake:

{"message":"Wait for cache sync","severity":"info","time":"2026-02-11T18:08:19.945724776Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"secrets\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc00081a038), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2026-02-11T18:08:19.946981374Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"multicluster.agones.dev\", Version:\"v1\", Resource:\"gameserverallocationpolicies\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000910028), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2026-02-11T18:08:19.947360993Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000012448), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2026-02-11T18:08:19.947518129Z"}
{"message":"Starting workers...","queue":"agones.dev.AllocationCache","severity":"info","source":"*gameserverallocations.AllocationCache","time":"2026-02-11T18:08:20.047127048Z","workers":1}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"multicluster.agones.dev\", Version:\"v1\", Resource:\"gameserverallocationpolicies\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000028948), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2026-02-11T18:08:20.940925748Z"}
{"message":"Starting http server...","severity":"info","test":"TestAllocationMetrics","time":"2026-02-11T18:08:21.053970361Z"}
{"error":"Could not listen on :3001: listen tcp :3001: bind: address already in use","message":"","severity":"error","test":"TestAllocationMetrics","time":"2026-02-11T18:08:21.059633335Z"}
{"message":"Could not listen on :3001: listen tcp :3001: bind: address already in use","severity":"error","stack":["agones.dev/agones/pkg/util/httpserver.(*Server).Run\n\t/go/src/agones.dev/agones/pkg/util/httpserver/server.go:58","agones.dev/agones/pkg/gameserverallocations.TestAllocationMetrics.func4\n\t/go/src/agones.dev/agones/pkg/gameserverallocations/metrics_test.go:204","runtime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1693"],"time":"2026-02-11T18:08:21.059945775Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000028f28), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2026-02-11T18:08:21.313856541Z"}
--- FAIL: TestAllocationMetrics (1.41s)
    metrics_test.go:209: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/metrics_test.go:209
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:3001/metrics": dial tcp 127.0.0.1:3001: connect: connection refused
        	Test:       	TestAllocationMetrics
        	Messages:   	Failed to GET metrics endpoint

/gcbrun

agones-bot · 2026-02-11T19:18:28Z

Build Succeeded 🥳

Build Id: 32697486-c62a-4c56-95ea-6f0e12e4849f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-f893dad
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-f893dad
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-f893dad-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-f893dad
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-f893dad
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-f893dad
Linux C++ SDK (build): agonessdk-1.56.0-dev-f893dad-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-f893dad.zip

A preview of the website (the last 30 builds are retained):

https://f893dad-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4439/head:pr_4439 && git checkout pr_4439
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-f893dad

* Added dark mode to the website- added the toggle for the mode, then fixed areas where the teme didnt apply properly. * Added apache licence * Update site/assets/scss/_darkmode-overrides.scss Co-authored-by: Mark Mandel <mark@compoundtheory.com> * Update site/assets/scss/_styles_project.scss Co-authored-by: Mark Mandel <mark@compoundtheory.com> --------- Co-authored-by: Mark Mandel <mark@compoundtheory.com> Co-authored-by: Sivasankaran R <sivasankaranr@google.com>

Added dark mode to the website- added the toggle for the mode, then f…

95bf330

…ixed areas where the teme didnt apply properly.

github-actions bot added kind/feature New features for Agones size/S labels Feb 8, 2026

Merge branch 'main' into Adding-Dark-Mode-to-the-Website

2e27321

markmandel reviewed Feb 8, 2026

View reviewed changes

markmandel mentioned this pull request Feb 11, 2026

site: update homepage showcase and navbar styling #4438

Merged

thegalacticlor added 2 commits February 10, 2026 23:24

Added apache licence

a54308c

Merge branch 'Adding-Dark-Mode-to-the-Website' of https://github.com/…

7189663

…thegalacticlor/agones into Adding-Dark-Mode-to-the-Website

Merge branch 'main' into Adding-Dark-Mode-to-the-Website

64d752e

markmandel reviewed Feb 11, 2026

View reviewed changes

site/assets/scss/_darkmode-overrides.scss Outdated Show resolved Hide resolved

site/assets/scss/_styles_project.scss Outdated Show resolved Hide resolved

thegalacticlor and others added 2 commits February 11, 2026 09:30

Update site/assets/scss/_darkmode-overrides.scss

5461489

Co-authored-by: Mark Mandel <mark@compoundtheory.com>

Update site/assets/scss/_styles_project.scss

f893dad

Co-authored-by: Mark Mandel <mark@compoundtheory.com>

markmandel approved these changes Feb 11, 2026

View reviewed changes

markmandel enabled auto-merge (squash) February 11, 2026 17:58

markmandel merged commit ddb1e7f into agones-dev:main Feb 11, 2026
5 checks passed

		@@ -0,0 +1,27 @@
		/* Dark mode overrides for the custom Agones navbar and UI */

		@@ -0,0 +1 @@
		@import "darkmode-overrides"; No newline at end of file

Conversation

thegalacticlor commented Feb 8, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel commented Feb 8, 2026

Uh oh!

agones-bot commented Feb 8, 2026

Uh oh!

markmandel commented Feb 9, 2026

Uh oh!

agones-bot commented Feb 9, 2026

Uh oh!

markmandel commented Feb 9, 2026

Uh oh!

thegalacticlor commented Feb 9, 2026

Uh oh!

markmandel commented Feb 9, 2026

Uh oh!

lacroixthomas commented Feb 10, 2026

Uh oh!

markmandel commented Feb 11, 2026

Uh oh!

thegalacticlor commented Feb 11, 2026

Uh oh!

Sivasankaran25 commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

agones-bot commented Feb 11, 2026

Uh oh!

thegalacticlor commented Feb 11, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel commented Feb 11, 2026

Uh oh!

agones-bot commented Feb 11, 2026

Uh oh!

markmandel commented Feb 11, 2026

Uh oh!

agones-bot commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants