Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Out of curiosity, do you want the same labels on both service monitors? Or would it be better to have the ability to set each individually? 🤔

Also noting that you'll need to write some docs for this too please!

This page will need updating: https://agones.dev/site/docs/installation/install-agones/helm/

See https://agones.dev/site/docs/contribute/documentation-editing-contribution/ for details on how to do documentation edits 👍🏻

Also noting that you'll need to write some docs for this too please!
This page will need updating: https://agones.dev/site/docs/installation/install-agones/helm/

Updated!

Out of curiosity, do you want the same labels on both service monitors? Or would it be better to have the ability to set each individually? 🤔

I think it's useful to apply to both of the ServiceMonitors because that's how the .Values.agones.metrics.serviceMonitor.interval helm parameter works right now too:

https://github.com/googleforgames/agones/pull/4424/files#diff-73a9a910a82e9ab1e3a20e1b28c9815b94dfa3d3a0500e215002860b6eae6943L138

@markmandel could I please ask if you could review this when you have a moment?

/gcbrun

Build Succeeded 🥳

Build Id: bb9e8e05-bd73-441b-97ab-64c1f770b6e7

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-26a72bf
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-26a72bf
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-26a72bf-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-26a72bf
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-26a72bf
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-26a72bf
• Linux C++ SDK (build): agonessdk-1.56.0-dev-26a72bf-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.56.0-dev-26a72bf.zip

A preview of the website (the last 30 builds are retained):

• https://26a72bf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4424/head:pr_4424 && git checkout pr_4424
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-26a72bf

/gcbrun

Build Succeeded 🥳

Build Id: e2a0c589-5faa-4008-8ea0-c7ce926ed21d

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-3e788c2
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-3e788c2
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-3e788c2-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-3e788c2
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-3e788c2
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-3e788c2
• Linux C++ SDK (build): agonessdk-1.56.0-dev-3e788c2-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.56.0-dev-3e788c2.zip

A preview of the website (the last 30 builds are retained):

• https://3e788c2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4424/head:pr_4424 && git checkout pr_4424
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-3e788c2

Thanks for your help, @markmandel ! 🚀