Fixes post_cloudbuild release by explicitly passing variables as Makefile arguments#4423
Merged
igooch merged 1 commit intoagones-dev:mainfrom Jan 14, 2026
Merged
Conversation
Collaborator
|
Build Succeeded 🥳 Build Id: 4d253e91-0154-4a1f-a2b0-deb0bcb53b1b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
vicentefb
reviewed
Jan 14, 2026
| env: ['VERSION=${_VERSION}', DOCKER_RUN_ARGS=--network=cloudbuild] | ||
| env: | ||
| - VERSION=${_VERSION} | ||
| - DOCKER_RUN_ARGS=--network=cloudbuild |
Collaborator
There was a problem hiding this comment.
just curious what's the other --network= option besides cloudbuild ?
Collaborator
Author
There was a problem hiding this comment.
The flag is a bit confusing as it's not changing the network, it's exposing the application default credentials in the cloudbuild network to a nested docker container. https://docs.cloud.google.com/build/docs/build-config-file-schema#network
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This PR updates the
post_cloudbuild.yamlscript to ensure that release build and push uses the correct version string and skips the development suffix.Specifically, it changes how
VERSIONandFULL_BUILDare passed to the make-docker steps. By moving these from environment variables to explicit command-line arguments, we force theMakefileto use the provided release version (e.g., 1.55.0).Previously, the Makefile was defaulting to a development version string (e.g., 1.55.0-dev-1b1c538) during the push-images step. The Cloud Build would fail, because the push-images step looked for development tags that did not match the release image tags correctly created in the previous build step.
Cloud Build push-images log:
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
Even though the
push-imagesstep was the failing step, I updated for allbuild-images,push-images, andpush-chartsteps for consistency.