fix(sdk): add validation to SetAnnotation to prevent infinite retry loop#4417
Conversation
|
Build Succeeded 🥳 Build Id: 3ead908e-1d7a-48d7-9746-532fb1f04cef The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
igooch
left a comment
There was a problem hiding this comment.
LGTM. Waiting to officially approve and merge until after today's release.
| return nil, status.Error(codes.InvalidArgument, "annotation key/value cannot be nil") | ||
| } | ||
|
|
||
| if errs := validation.IsQualifiedName(kv.Key); len(errs) > 0 { |
There was a problem hiding this comment.
FYI: validation.IsQualifiedName will be deprecated in k8s.io/apimachinery v0.35. We are currently on v0.33 to align with our middle supported version of Kubernetes 1.33. We should migrate to the new function once our middle supported version shifts to 1.35, as the new function is not available until v0.35.
There was a problem hiding this comment.
@igooch Added TODO comments for post–Kubernetes 0.35 migration and will create a new issue to track this.
|
Build Succeeded 🥳 Build Id: ca5d8ed1-49cb-49dc-8739-0613a19d52a5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
…oop (agones-dev#4417) * fix(sdk): add validation to SetAnnotation to prevent infinite retry loop * add TODO for IsQualifiedName deprecation in k8s v0.35
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #4409
Special notes for your reviewer: