fix: Ensure the processclient have a correct timeout / fix flacky test by lacroixthomas · Pull Request #4402 · agones-dev/agones

lacroixthomas · 2025-12-28T23:11:24Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind bug

What this PR does / Why we need it:

Fix flacky test around processor client and a 50ms allocation timeout

Which issue(s) this PR fixes:

Closes #4400

Special notes for your reviewer:

I've been running this test 500 time with parallel and with many scenarios, but sadly I had the same result with the fix and without it, wasn't able to reproduce it, but I'm pretty confident it's coming from that

lacroixthomas · 2025-12-28T23:52:24Z

I wasn't able to reproduce it locally, but been doing quite a lot of test with it, I'm pretty sure this fix the issue 😄

agones-bot · 2025-12-29T00:17:22Z

Build Succeeded 🥳

Build Id: 37c0f42c-0af3-4c75-9ccb-497595df3c8c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-1132164-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-1132164
Linux C++ SDK (build): agonessdk-1.55.0-dev-1132164-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-1132164.zip

A preview of the website (the last 30 builds are retained):

https://1132164-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4402/head:pr_4402 && git checkout pr_4402
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-1132164

lacroixthomas · 2025-12-29T00:19:26Z

/gcbrun

agones-bot · 2025-12-29T01:45:41Z

Build Succeeded 🥳

Build Id: 17086c70-bdb7-4d78-a401-2bf04f3b7de8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-1132164-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-1132164
Linux C++ SDK (build): agonessdk-1.55.0-dev-1132164-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-1132164.zip

A preview of the website (the last 30 builds are retained):

https://1132164-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4402/head:pr_4402 && git checkout pr_4402
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-1132164

lacroixthomas · 2025-12-29T02:07:05Z

/gcbrun

agones-bot · 2025-12-29T03:13:49Z

Build Succeeded 🥳

Build Id: 66898655-6679-4b7d-bd7f-e14b9a034813

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-1132164-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-1132164
Linux C++ SDK (build): agonessdk-1.55.0-dev-1132164-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-1132164.zip

A preview of the website (the last 30 builds are retained):

https://1132164-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4402/head:pr_4402 && git checkout pr_4402
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-1132164

lacroixthomas · 2025-12-29T19:45:59Z

/gcbrun

agones-bot · 2025-12-29T19:58:44Z

Build Failed 😭

Build Id: 5f78cbd2-0d82-4691-a9bb-a98ac0679f23

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-12-29T20:30:04Z

TestControllerGameServersNodeState already an issue open for that

/gcbrun

agones-bot · 2025-12-29T22:02:02Z

Build Succeeded 🥳

Build Id: e7fd9860-9273-4be6-b52d-5e80e9ad1cb1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-1132164-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-1132164
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-1132164
Linux C++ SDK (build): agonessdk-1.55.0-dev-1132164-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-1132164.zip

A preview of the website (the last 30 builds are retained):

https://1132164-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4402/head:pr_4402 && git checkout pr_4402
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-1132164

pkg/processor/client_test.go

agones-bot · 2026-01-09T00:33:15Z

Build Succeeded 🥳

Build Id: 1dcbe975-fde4-4960-b3db-e5a4b9638759

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-d2852d7
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-d2852d7
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-d2852d7-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-d2852d7
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-d2852d7
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-d2852d7
Linux C++ SDK (build): agonessdk-1.55.0-dev-d2852d7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-d2852d7.zip

A preview of the website (the last 30 builds are retained):

https://d2852d7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4402/head:pr_4402 && git checkout pr_4402
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-d2852d7

agones-bot · 2026-01-11T03:39:18Z

Build Succeeded 🥳

Build Id: e8ab54fe-2c8d-45ef-ae22-8e8093578e9c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-3c8f882
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-3c8f882
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-3c8f882-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-3c8f882
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-3c8f882
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-3c8f882
Linux C++ SDK (build): agonessdk-1.55.0-dev-3c8f882-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-3c8f882.zip

A preview of the website (the last 30 builds are retained):

https://3c8f882-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4402/head:pr_4402 && git checkout pr_4402
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-3c8f882

markmandel

Always appreciate an Eventually over a sleep! 👍🏻

agones-bot · 2026-01-16T17:50:33Z

Build Succeeded 🥳

Build Id: 155f7c35-6a9d-4f7e-819f-c13a124192f4

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-07ca4f9
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-07ca4f9
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-07ca4f9-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-07ca4f9
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-07ca4f9
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-07ca4f9
Linux C++ SDK (build): agonessdk-1.56.0-dev-07ca4f9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-07ca4f9.zip

A preview of the website (the last 30 builds are retained):

https://07ca4f9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4402/head:pr_4402 && git checkout pr_4402
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-07ca4f9

agones-dev#4402) * fix: Ensure the processclient have a correct timeout / fix flacky test * fix: use assert.Eventually instead of manual ticker

fix: Ensure the processclient have a correct timeout / fix flacky test

1132164

github-actions bot added kind/bug These are bugs. size/S labels Dec 28, 2025

lacroixthomas requested review from igooch and markmandel January 5, 2026 21:12

lacroixthomas commented Jan 8, 2026

View reviewed changes

pkg/processor/client_test.go Outdated Show resolved Hide resolved

fix: use assert.Eventually instead of manual ticker

d2852d7

Merge branch 'main' into bugfixes/4400-flacky-unit-test-processor-client

3c8f882

markmandel approved these changes Jan 16, 2026

View reviewed changes

markmandel enabled auto-merge (squash) January 16, 2026 16:39

Merge branch 'main' into bugfixes/4400-flacky-unit-test-processor-client

07ca4f9

markmandel merged commit 2aafbba into agones-dev:main Jan 16, 2026
5 checks passed

Conversation

lacroixthomas commented Dec 28, 2025

Uh oh!

lacroixthomas commented Dec 28, 2025

Uh oh!

agones-bot commented Dec 29, 2025

Uh oh!

lacroixthomas commented Dec 29, 2025

Uh oh!

agones-bot commented Dec 29, 2025

Uh oh!

lacroixthomas commented Dec 29, 2025

Uh oh!

agones-bot commented Dec 29, 2025

Uh oh!

lacroixthomas commented Dec 29, 2025

Uh oh!

agones-bot commented Dec 29, 2025

Uh oh!

lacroixthomas commented Dec 29, 2025

Uh oh!

agones-bot commented Dec 29, 2025

Uh oh!

Uh oh!

agones-bot commented Jan 9, 2026

Uh oh!

agones-bot commented Jan 11, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Jan 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants