Build simple-game-server in CI for e2e tests by IrvingMg · Pull Request #4401 · agones-dev/agones

IrvingMg · 2025-12-28T17:55:41Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:
Automates building simple-game-server in CI for e2e tests.

Which issue(s) this PR fixes:

Special notes for your reviewer:

lacroixthomas

Hi @IrvingMg !
Thanks for the contribution ! 🎉

I've put some minor changes, but I'm still looking into it, I wonder if we could not do as the other process (by using the Makefile to setup the version directly (release one or with hash)) and to push it, because it's actually the case for the controller, allocator, extensions etc. 🤔)

Your changes looks all good, but I wonder if we can not make it more consistent with the others, which might simplify things as well

I'll come back to you ASAP once I've had a deeper look at it 😄

cloudbuild.yaml

markmandel · 2026-01-09T04:20:07Z

Just having a peek around 😄 +1 on what @lacroixthomas said about putting it in the Makefile.

If you set the version to be an over writable parameter, like we do for registry,

https://github.com/googleforgames/agones/blob/38db980c8a46ea1514b222c0ad1d28dddb977263/examples/simple-game-server/Makefile#L42

Then the step should become basically the same as here:

https://github.com/googleforgames/agones/blob/38db980c8a46ea1514b222c0ad1d28dddb977263/examples/simple-game-server/cloudbuild.yaml#L26-L33

markmandel · 2026-01-16T16:41:38Z

Just checking in to see if you need any extra help with this?

/gcbrun

markmandel · 2026-01-16T16:42:05Z

/gcbrun

markmandel · 2026-01-16T16:44:40Z

generic::invalid_argument: invalid value for 'build.substitutions': key in the template "SGS_IMAGE" is not a valid built-in substitution

Looks like there is also an issue on the cloud build setup too.

IrvingMg · 2026-01-16T17:32:25Z

Just checking in to see if you need any extra help with this?

Thanks for checking in and for the review, sorry for the delay. I’ll apply the changes this weekend.

IrvingMg · 2026-01-17T10:44:34Z

I've applied the requested changes. The build step is now using the ${_REGISTRY} variable and the Makefile approach with an overridable VERSION.

Thanks for your patience!

markmandel · 2026-01-20T03:37:56Z

This looks really good!

markmandel · 2026-01-20T03:39:19Z

/gcbrun

markmandel · 2026-01-20T03:48:50Z

ruh ROH - invalid Cloud Build syntax:

generic::invalid_argument: invalid value for 'build.substitutions': key in the template "SGS_IMAGE" is not a valid built-in substitution

cloudbuild.yaml

markmandel · 2026-01-20T16:15:49Z

/gcbrun

agones-bot · 2026-01-20T17:58:32Z

Build Succeeded 🥳

Build Id: c0b6e5b2-f202-4509-bd44-25dd054239f8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-59f1037
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-59f1037
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-59f1037-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-59f1037
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-59f1037
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-59f1037
Linux C++ SDK (build): agonessdk-1.56.0-dev-59f1037-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-59f1037.zip

A preview of the website (the last 30 builds are retained):

https://59f1037-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4401/head:pr_4401 && git checkout pr_4401
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-59f1037

markmandel · 2026-01-21T17:27:19Z

This LGTM! - @lacroixthomas anything else you want to review?

lacroixthomas · 2026-01-21T17:31:32Z

This LGTM! - @lacroixthomas anything else you want to review?

Looking great ! LGTM

markmandel · 2026-01-21T18:11:16Z

/gcbrun

agones-bot · 2026-01-21T19:10:32Z

Build Succeeded 🥳

Build Id: 7d9d3e39-d48b-433e-9f26-14ba93f5743e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-e2f0e0d
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-e2f0e0d
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-e2f0e0d-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-e2f0e0d
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-e2f0e0d
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-e2f0e0d
Linux C++ SDK (build): agonessdk-1.56.0-dev-e2f0e0d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-e2f0e0d.zip

A preview of the website (the last 30 builds are retained):

https://e2f0e0d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4401/head:pr_4401 && git checkout pr_4401
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-e2f0e0d

Co-authored-by: Thomas Lacroix <thomas.lacroix@ubisoft.com>

github-actions bot added kind/feature New features for Agones size/S labels Dec 28, 2025

lacroixthomas reviewed Dec 29, 2025

View reviewed changes

cloudbuild.yaml Outdated Show resolved Hide resolved

IrvingMg force-pushed the rebuild-simple-game-server-e2e-tests branch from e3f887f to 3494334 Compare January 17, 2026 10:40

markmandel reviewed Jan 20, 2026

View reviewed changes

cloudbuild.yaml Outdated Show resolved Hide resolved

IrvingMg force-pushed the rebuild-simple-game-server-e2e-tests branch from 7685c4c to 286885e Compare January 20, 2026 10:13

Build simple-game-server in CI for e2e tests

59f1037

IrvingMg force-pushed the rebuild-simple-game-server-e2e-tests branch from 286885e to 59f1037 Compare January 20, 2026 10:16

Merge branch 'main' into rebuild-simple-game-server-e2e-tests

59d4d1d

lacroixthomas approved these changes Jan 21, 2026

View reviewed changes

markmandel approved these changes Jan 21, 2026

View reviewed changes

Merge branch 'main' into rebuild-simple-game-server-e2e-tests

e2f0e0d

markmandel enabled auto-merge (squash) January 21, 2026 18:11

markmandel merged commit 8f0f65f into agones-dev:main Jan 21, 2026
5 checks passed

IrvingMg deleted the rebuild-simple-game-server-e2e-tests branch January 22, 2026 12:23

mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026

Build simple-game-server in CI for e2e tests (agones-dev#4401)

fc68864

Co-authored-by: Thomas Lacroix <thomas.lacroix@ubisoft.com>

Conversation

IrvingMg commented Dec 28, 2025

Uh oh!

lacroixthomas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

markmandel commented Jan 9, 2026

Uh oh!

markmandel commented Jan 16, 2026

Uh oh!

markmandel commented Jan 16, 2026

Uh oh!

markmandel commented Jan 16, 2026

Uh oh!

IrvingMg commented Jan 16, 2026

Uh oh!

IrvingMg commented Jan 17, 2026

Uh oh!

markmandel commented Jan 20, 2026

Uh oh!

markmandel commented Jan 20, 2026

Uh oh!

markmandel commented Jan 20, 2026

Uh oh!

Uh oh!

markmandel commented Jan 20, 2026

Uh oh!

agones-bot commented Jan 20, 2026

Uh oh!

markmandel commented Jan 21, 2026

Uh oh!

lacroixthomas commented Jan 21, 2026

Uh oh!

markmandel commented Jan 21, 2026

Uh oh!

agones-bot commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants