Skip to content

feat: refactored to use SumGameServerSets#4398

Merged
markmandel merged 1 commit intoagones-dev:mainfrom
Ledovecek:main
Dec 27, 2025
Merged

feat: refactored to use SumGameServerSets#4398
markmandel merged 1 commit intoagones-dev:mainfrom
Ledovecek:main

Conversation

@Ledovecek
Copy link
Copy Markdown
Contributor

@Ledovecek Ledovecek commented Dec 25, 2025

What type of PR is this?

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Refactors the replica counting logic by replacing the legacy Sum* and GetReadyReplicaCountForGameServerSets functions with the higher-level abstraction. This cleanup addresses the technical debt highlighted in the code comments, unifies the counting mechanism, and removes redundant code.

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Dec 25, 2025
@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Dec 26, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Dec 26, 2025

Build Failed 😭

Build Id: bd8435f5-99ce-4101-8bb4-ba8bb5c16bf9

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Copy Markdown
Collaborator

lacroixthomas commented Dec 26, 2025

Thanks for contribution @Ledovecek !

This seems to be the flaky test from this issue, not related to your changes #4390 , gonna re-run the pipeline

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Dec 26, 2025

Build Failed 😭

Build Id: 2ffce5dc-f054-4a31-af2b-340572a71927

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Sivasankaran25
Copy link
Copy Markdown
Collaborator

Sivasankaran25 commented Dec 26, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Dec 26, 2025

Build Succeeded 🥳

Build Id: 255f6edf-755f-4d69-9079-be411ce42068

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4398/head:pr_4398 && git checkout pr_4398
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-5fc03f1

@lacroixthomas
Copy link
Copy Markdown
Collaborator

lacroixthomas commented Dec 26, 2025

Build Failed 😭

Build Id: 2ffce5dc-f054-4a31-af2b-340572a71927

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

This one was coming from another flacky test: #4391

lacroixthomas
lacroixthomas approved these changes Dec 26, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lacroixthomas lacroixthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit 5228cee into agones-dev:main Dec 27, 2025
6 checks passed
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
@Ledovecek @mnthe
feat: refactored to use SumGameServerSets (agones-dev#4398)
5f7b623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lacroixthomas lacroixthomas lacroixthomas approved these changes

Assignees

No one assigned

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ledovecek @markmandel @agones-bot @lacroixthomas @Sivasankaran25