Fix flaky TestControllerGameServerCount race condition#4392
Merged
markmandel merged 2 commits intoagones-dev:mainfrom Dec 18, 2025
Merged
Fix flaky TestControllerGameServerCount race condition#4392markmandel merged 2 commits intoagones-dev:mainfrom
markmandel merged 2 commits intoagones-dev:mainfrom
Conversation
The test was flaky due to a race condition in the wait loop. The condition only checked that 4 time series existed (len(m.TimeSeries) == 4), but did not verify the actual count values. This allowed the test to proceed even when only 1 of 2 PortAllocation GameServers had been added to the informer cache. The fix updates the wait condition to explicitly verify that the PortAllocation metric has a count of 2 before proceeding to assertions. This ensures both GameServers are present in the cache and counted correctly, eliminating the race condition. Closes agones-dev#4389
7b4fe73 to
d9d9f4b
Compare
Collaborator
|
Build Succeeded 🥳 Build Id: b10926fc-124a-4876-acf1-1d5e9bd450fc The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Collaborator
|
Build Failed 😭 Build Id: 5c2ab7cd-f872-4c18-b3c9-1a232f44ea98 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Collaborator
Author
|
/gcbrun |
Collaborator
|
Build Failed 😭 Build Id: 9057fb67-573f-4fbe-a082-c62de9ef3c1b Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Collaborator
Author
|
/gcbrun |
Collaborator
|
Build Succeeded 🥳 Build Id: a1872f61-e958-421a-b643-4ff15cd2ec56 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
The test was flaky due to a race condition in the wait loop. The condition only checked that 4 time series existed (len(m.TimeSeries) == 4), but did not verify the actual count values. This allowed the test to proceed even when only 1 of 2 PortAllocation GameServers had been added to the informer cache. The fix updates the wait condition to explicitly verify that the PortAllocation metric has a count of 2 before proceeding to assertions. This ensures both GameServers are present in the cache and counted correctly, eliminating the race condition. Closes agones-dev#4389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
The test was flaky due to a race condition in the wait loop. The condition only checked that 4 time series existed (len(m.TimeSeries) == 4), but did not verify the actual count values. This allowed the test to proceed even when only 1 of 2 PortAllocation GameServers had been added to the informer cache.
The fix updates the wait condition to explicitly verify that the PortAllocation metric has a count of 2 before proceeding to assertions. This ensures both GameServers are present in the cache and counted correctly, eliminating the race condition.
Which issue(s) this PR fixes:
Closes #4389
Special notes for your reviewer: