test: deferred cleanup for GameServer in TestSuperTuxKartGameServerReady#4379
Merged
markmandel merged 2 commits intoagones-dev:mainfrom Dec 10, 2025
Merged
Conversation
Add a deferred function to properly delete the GameServer after the test completes, ensuring resources are cleaned up even if the test fails. Also update error handling to check if readyGs is not nil before logging events. This makes rerunning the test hundreds of time to check for flakes much easier without a super large cluster.
Collaborator
|
Build Succeeded 🥳 Build Id: 02d54f93-47c4-4f37-aa15-278bb9f47df6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
lacroixthomas
approved these changes
Dec 10, 2025
Collaborator
lacroixthomas
left a comment
There was a problem hiding this comment.
Oooh good catch, not sure we clean up the ressources all the times even from other e2e in case of errors, could definitively be an issue
LGTM !
Collaborator
|
Build Succeeded 🥳 Build Id: c1f99382-c075-448b-b5e5-83bd74607168 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
…ady (agones-dev#4379) Add a deferred function to properly delete the GameServer after the test completes, ensuring resources are cleaned up even if the test fails. Also update error handling to check if readyGs is not nil before logging events. This makes rerunning the test hundreds of time to check for flakes much easier without a super large cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Add a deferred function to properly delete the GameServer after the test completes, ensuring resources are cleaned up even if the test fails. Also update error handling to check if readyGs is not nil before logging events.
This makes rerunning the test hundreds of time to check for flakes much easier without a super large cluster.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A