Skip to content

Adds the build environment image to the pre_cloudbuild pipeline#4372

Merged
igooch merged 1 commit intoagones-dev:mainfrom
igooch:precloudbuild
Dec 3, 2025
Merged

Adds the build environment image to the pre_cloudbuild pipeline#4372
igooch merged 1 commit intoagones-dev:mainfrom
igooch:precloudbuild

Conversation

@igooch
Copy link
Copy Markdown
Collaborator

@igooch igooch commented Dec 3, 2025

What type of PR is this?

/kind hotfix

What this PR does / Why we need it:

When running make pre-build-release VERSION=1.54.0 the Cloudbuild run gives the error:

Starting Step #4 - "test-examples-on-gar"
Step #4 - "test-examples-on-gar": Already have image: make-docker
Step #4 - "test-examples-on-gar": docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones --network=cloudbuild agones-build:a8d1f85932 bash -c "cd examples/allocation-endpoint && make gar-check"
Step #4 - "test-examples-on-gar": Unable to find image 'agones-build:a8d1f85932' locally
Step #4 - "test-examples-on-gar": docker: Error response from daemon: pull access denied for agones-build, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
Step #4 - "test-examples-on-gar": See 'docker run --help'.
Step #4 - "test-examples-on-gar": make: *** [includes/examples.mk:51: example-image-test.allocation-endpoint] Error 125
Finished Step #4 - "test-examples-on-gar"
ERROR
ERROR: build step 4 "make-docker" failed: step exited with non-zero status: 2

Looks like this is due to the make test-examples-on-gar being dependent on having the build environment image available in the Cloudbuild environment. We fix this by adding back the pull-build-image that had been removed in a previous PR. We also add in the ensure-build-image as the pull-build-image will fail silently if it cannot pull the image.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

@github-actions github-actions bot added kind/hotfix Hotfixes for issues against release size/S labels Dec 3, 2025
@igooch igooch enabled auto-merge (squash) December 3, 2025 00:45
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 5c91c767-bd85-4089-ab83-3b9c4dbc28bc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4372/head:pr_4372 && git checkout pr_4372
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-fd3717f

@igooch igooch merged commit 6374cf6 into agones-dev:main Dec 3, 2025
4 checks passed
igooch added a commit that referenced this pull request Dec 3, 2025
* Adds back the build environment image to the precloudbuild pipeline (#4372)

* Release v1.54.0

* update pre cloudbuild file

---------

Co-authored-by: igooch <igooch@google.com>
igooch added a commit that referenced this pull request Dec 4, 2025
* Adds back the build environment image to the precloudbuild pipeline (#4372)

* Release v1.54.0

* update pre cloudbuild file

---------

Co-authored-by: igooch <igooch@google.com>
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
* Adds back the build environment image to the precloudbuild pipeline (agones-dev#4372)

* Release v1.54.0

* update pre cloudbuild file

---------

Co-authored-by: igooch <igooch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/hotfix Hotfixes for issues against release size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants