More fixes for SuperTuxKart example to attempt to fix flakiness.#4359
Merged
markmandel merged 2 commits intoagones-dev:mainfrom Dec 1, 2025
Merged
More fixes for SuperTuxKart example to attempt to fix flakiness.#4359markmandel merged 2 commits intoagones-dev:mainfrom
markmandel merged 2 commits intoagones-dev:mainfrom
Conversation
I've run this several hundred times on my Minikube cluster, and so far it has failed to fail! My theory is that the log file is doing something weird with the log file before it really starts pushing logs to it -- and therefore occasionally will assume there is no log at all. To fix this I made the following changes: - Bump version from 0.20 to 0.21 in Makefile, fleet.yaml, and gameserver.yaml - Update Agones SDK from v1.51.0 to v1.53.0 - Replace deprecated hpcloud/tail with nxadm/tail v1.4.11 - Fix Dockerfile syntax: change 'as' to 'AS' for build stage - Enhance log file monitoring with existence and size checks before tailing Work on agones-dev#4321
ffd867b to
12a748d
Compare
Collaborator
|
Build Succeeded 🥳 Build Id: 6956fb61-958d-4f5d-9ad5-0bd295206936 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Collaborator
|
The build has been pushed: us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.21 from what I see |
Collaborator
|
Build Succeeded 🥳 Build Id: d1d1432b-ba59-406a-95a9-ab72e4bea70c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
…nes-dev#4359) I've run this several hundred times on my Minikube cluster, and so far it has failed to fail! My theory is that the log file is doing something weird with the log file before it really starts pushing logs to it -- and therefore occasionally will assume there is no log at all. To fix this I made the following changes: - Bump version from 0.20 to 0.21 in Makefile, fleet.yaml, and gameserver.yaml - Update Agones SDK from v1.51.0 to v1.53.0 - Replace deprecated hpcloud/tail with nxadm/tail v1.4.11 - Fix Dockerfile syntax: change 'as' to 'AS' for build stage - Enhance log file monitoring with existence and size checks before tailing Work on agones-dev#4321 Co-authored-by: Thomas Lacroix <thomas.lacroix@ubisoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
I've run this several hundred times on my Minikube cluster, and so far it has failed to fail!
My theory is that the log file is doing something weird with the log file before it really starts pushing logs to it -- and therefore occasionally will assume there is no log at all.
To fix this I made the following changes:
Which issue(s) this PR fixes:
Work on #4321
Special notes for your reviewer:
Like last time, will update the e2e test once this has merged and the image is up on the registry.