Fix: ensure the uninstall wait to be properly done by lacroixthomas · Pull Request #4355 · agones-dev/agones

lacroixthomas · 2025-11-26T23:51:10Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind bug

What this PR does / Why we need it:
Ensure we wait (with a timeout of 10m) for the helm uninstall when doing a helm upgrade --install, to ensure there is no race condition between the resources from the previous version installed and the new one

Which issue(s) this PR fixes:

Closes #4354

Special notes for your reviewer:

markmandel · 2025-11-26T23:59:43Z

build/Makefile

 install: HELM_ARGS ?=
 install: $(ensure-build-image) install-custom-pull-secret
-	-$(DOCKER_RUN) bash -c '[[ $$(helm status agones -n agones-system --output json | jq -r ".info.status") =~ (failed|pending-.*) ]] && helm uninstall agones --namespace=agones-system || true'
+	-$(DOCKER_RUN) bash -c '[[ $$(helm status agones -n agones-system --output json | jq -r ".info.status") =~ (failed|pending-.*) ]] && helm uninstall agones --namespace=agones-system --wait --timeout=10m || true'


(non blocking) Should we make the timeout 20m? 30m? Just in case

I've put 10 mins to match the timeout from the install, but I don't mind increasing it to 20m in case there is something really blocking during the uninstall (it should uninstall the helm release only if it's in failed or pending)

Will let the pipeline finish and will push this change 👌🏼

agones-bot · 2025-11-27T01:13:55Z

Build Succeeded 🥳

Build Id: 4302d77d-9347-4248-af4f-d7b00ec8ca3c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-a44cd46
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-a44cd46
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-a44cd46-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-a44cd46
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-a44cd46
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-a44cd46
Linux C++ SDK (build): agonessdk-1.54.0-dev-a44cd46-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-a44cd46.zip

A preview of the website (the last 30 builds are retained):

https://a44cd46-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4355/head:pr_4355 && git checkout pr_4355
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-a44cd46

agones-bot · 2025-11-27T02:18:29Z

Build Succeeded 🥳

Build Id: adb444cc-4f10-4b32-9032-0e37ecd5c344

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-f88cf20-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-f88cf20
Linux C++ SDK (build): agonessdk-1.54.0-dev-f88cf20-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-f88cf20.zip

A preview of the website (the last 30 builds are retained):

https://f88cf20-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4355/head:pr_4355 && git checkout pr_4355
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-f88cf20

lacroixthomas · 2025-11-27T03:52:38Z

/gcbrun
Trying to make it fails to see the logs (at least the previous helmrelease in fail)

agones-bot · 2025-11-27T04:49:58Z

Build Succeeded 🥳

Build Id: dd590481-4b24-4d3b-985b-d3794133a13a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-f88cf20-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-f88cf20
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-f88cf20
Linux C++ SDK (build): agonessdk-1.54.0-dev-f88cf20-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-f88cf20.zip

A preview of the website (the last 30 builds are retained):

https://f88cf20-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4355/head:pr_4355 && git checkout pr_4355
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-f88cf20

markmandel · 2025-11-27T14:51:18Z

It's a pretty rare failure state. Might just be easier to merge and wait and see if it pops its head up again ☺️

agones-bot · 2025-11-27T18:32:56Z

Build Succeeded 🥳

Build Id: 30a00156-dcad-44e4-a504-844a865ba1a2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-32ef3ec
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-32ef3ec
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-32ef3ec-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-32ef3ec
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-32ef3ec
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-32ef3ec
Linux C++ SDK (build): agonessdk-1.54.0-dev-32ef3ec-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-32ef3ec.zip

A preview of the website (the last 30 builds are retained):

https://32ef3ec-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4355/head:pr_4355 && git checkout pr_4355
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-32ef3ec

* fix: ensure the uninstall wait to be properly done * Fix: add more logs around previous invalid helm release state

fix: ensure the uninstall wait to be properly done

a44cd46

github-actions bot added kind/bug These are bugs. size/XS labels Nov 26, 2025

markmandel approved these changes Nov 26, 2025

View reviewed changes

Fix: add more logs around previous invalid helm release state

f88cf20

Merge branch 'main' into bugfixes/e2e-race-condition-uninstall-upgrade

32ef3ec

lacroixthomas enabled auto-merge (squash) November 27, 2025 17:36

lacroixthomas merged commit b348988 into agones-dev:main Nov 27, 2025
4 checks passed

mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026

Fix: ensure the uninstall wait to be properly done (agones-dev#4355)

1d0774b

* fix: ensure the uninstall wait to be properly done * Fix: add more logs around previous invalid helm release state

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: ensure the uninstall wait to be properly done#4355

Fix: ensure the uninstall wait to be properly done#4355
lacroixthomas merged 3 commits intoagones-dev:mainfrom
lacroixthomas:bugfixes/e2e-race-condition-uninstall-upgrade

lacroixthomas commented Nov 26, 2025

Uh oh!

markmandel Nov 26, 2025

Uh oh!

lacroixthomas Nov 27, 2025

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

lacroixthomas commented Nov 27, 2025

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

markmandel commented Nov 27, 2025

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lacroixthomas commented Nov 26, 2025

Uh oh!

markmandel Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

lacroixthomas Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

lacroixthomas commented Nov 27, 2025

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

markmandel commented Nov 27, 2025

Uh oh!

agones-bot commented Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants