Skip to content

Exclude wasm from example image check#4353

Merged
markmandel merged 2 commits intoagones-dev:mainfrom
igooch:exclude-wasm
Nov 27, 2025
Merged

Exclude wasm from example image check#4353
markmandel merged 2 commits intoagones-dev:mainfrom
igooch:exclude-wasm

Conversation

@igooch
Copy link
Copy Markdown
Collaborator

@igooch igooch commented Nov 26, 2025

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

When running make check-example-versions we get the error:

2025/11/26 22:31:51 Getting versions of autoscaler-wasm
2025/11/26 22:31:51 Could not get (local) version of example autoscaler-wasm: no version could be found
exit status 1

The example currently uses a path to the raw file, not to a Docker container in a registry like the rest of the examples, so there is no need to check for a Docker image.

https://github.com/googleforgames/agones/blob/0007c692714701a8d127567e40311ae5e6eec61a/examples/autoscaler-wasm/autoscaler.yaml#L39

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

@igooch igooch requested a review from markmandel November 26, 2025 22:56
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Nov 26, 2025
@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Nov 26, 2025

Good catch!

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Nov 26, 2025

Build Failed 😭

Build Id: 28d0549a-226e-433e-b3e8-567c6e8e4c30

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Sivasankaran25
Copy link
Copy Markdown
Collaborator

Sivasankaran25 commented Nov 27, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Nov 27, 2025

Build Succeeded 🥳

Build Id: a05b783c-1030-45ca-817c-cf3ec4d5a358

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4353/head:pr_4353 && git checkout pr_4353
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-66196a8

@markmandel markmandel enabled auto-merge (squash) November 27, 2025 18:45
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Nov 27, 2025

Build Succeeded 🥳

Build Id: 64194b46-e8a5-4418-8413-1970e7eaf88a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4353/head:pr_4353 && git checkout pr_4353
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-a30e2a0

@markmandel markmandel merged commit 399d06f into agones-dev:main Nov 27, 2025
4 checks passed
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
@igooch @mnthe
Exclude wasm from example check (agones-dev#4353)
f00fd5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmandel markmandel markmandel approved these changes

Assignees

No one assigned

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igooch @markmandel @agones-bot @Sivasankaran25