Skip to content

cleanup(examples): Upgrade SuperTuxKart and increase timeout.#4338

Merged
igooch merged 2 commits intoagones-dev:mainfrom
markmandel:examples/stk
Nov 19, 2025
Merged

cleanup(examples): Upgrade SuperTuxKart and increase timeout.#4338
igooch merged 2 commits intoagones-dev:mainfrom
markmandel:examples/stk

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

@markmandel markmandel commented Nov 19, 2025

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Updated to the latest supertuxkart, and also allowed up to a minute to check for the log file to get created. 🤞 this solves the flakiness issue.

Which issue(s) this PR fixes:

Work on #4321

Special notes for your reviewer:

Will do the updates to e2e tests once this is merged. I've tested it and it all works.

@markmandel
cleanup(examples): Upgrade SuperTuxKart and increase timeout.
5d384ab 
Updated to the latest supertuxkart, and also allowed up to a minute to
check for the log file to get created. 🤞 this solves the flakiness
issue.

Work on agones-dev#4321
@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label Nov 19, 2025
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Nov 19, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Nov 19, 2025

Build Succeeded 🥳

Build Id: 1e73220e-78df-4301-8b86-94dcef59e181

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4338/head:pr_4338 && git checkout pr_4338
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-5d384ab

igooch
igooch reviewed Nov 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to get upgraded as well? https://github.com/googleforgames/agones/blob/5ebc2d9bdde9742b012625c4f95822cb07fd6c76/test/e2e/examples_test.go#L57

@markmandel
Copy link
Copy Markdown
Collaborator Author

markmandel commented Nov 19, 2025

@igooch

Will do the updates to e2e tests once this is merged. I've tested it and it all works.

This is part 1 so we can merge this, someone on your end with permissions push the new image up, then I can fix the e2e tests once the image is live.

igooch
igooch approved these changes Nov 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch
Copy link
Copy Markdown
Collaborator

igooch commented Nov 19, 2025

@igooch

Will do the updates to e2e tests once this is merged. I've tested it and it all works.

This is part 1 so we can merge this, someone on your end with permissions push the new image up, then I can fix the e2e tests once the image is live.

@Sivasankaran25 @indurireddy-TF

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Nov 19, 2025

Build Succeeded 🥳

Build Id: 4e8513d3-e880-432c-8a87-538d06f81d4a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4338/head:pr_4338 && git checkout pr_4338
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-5e96cf6

@igooch igooch merged commit b5b5a68 into agones-dev:main Nov 19, 2025
4 checks passed
@markmandel markmandel deleted the examples/stk branch November 22, 2025 23:46
@igooch igooch mentioned this pull request Nov 24, 2025
Closed
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
@markmandel @igooch @mnthe
cleanup(examples): Upgrade SuperTuxKart and increase timeout. (agones…
d20a67f 
…-dev#4338)

Updated to the latest supertuxkart, and also allowed up to a minute to
check for the log file to get created. 🤞 this solves the flakiness
issue.

Work on agones-dev#4321

Co-authored-by: igooch <igooch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igooch igooch igooch approved these changes

@lacroixthomas lacroixthomas Awaiting requested review from lacroixthomas

Assignees

No one assigned

Labels

area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markmandel @agones-bot @igooch