[Unreal] Add counters support to status by GloryOfNight · Pull Request #4333 · agones-dev/agones

GloryOfNight · 2025-11-12T09:02:45Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

add counter structure to status
fix spaces to tabs

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:
Recently we introduced that change internally, just wanted to share.

GloryOfNight · 2025-11-17T11:03:41Z

sorry, forgot to attach the file 😓
build.log

markmandel · 2025-11-18T01:55:41Z

/gcbrun

markmandel · 2025-11-18T01:56:51Z

@keith-miller may I have your eyes on this?

Copilot

Pull Request Overview

This PR adds support for counters in the Unreal SDK's status structure and fixes whitespace formatting issues by converting spaces to tabs for consistency with the codebase style.

Key changes:

Added new FCounter struct to represent counter objects with Count and Capacity fields
Integrated counters map into FStatus struct to parse counter data from JSON responses
Fixed whitespace formatting in AgonesSubsystem.cpp by replacing spaces with tabs

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.

File	Description
sdks/unreal/Agones/Source/Agones/Classes/Classes.h	Adds `FCounter` struct definition and integrates `TMap<FString, FCounter>` into `FStatus`; fixes tab indentation in `FCounterResponse`
sdks/unreal/Agones/Source/Agones/Private/AgonesSubsystem.cpp	Replaces trailing spaces with tabs in lambda functions for `GetList`, `UpdateList`, `AddListValue`, and `RemoveListValue` methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-18T01:59:17Z

sdks/unreal/Agones/Source/Agones/Classes/Classes.h

+	UPROPERTY(BlueprintReadOnly, Category = "Agones")
+	int32 Count = 0;
+
+	UPROPERTY(BlueprintReadOnly, Category = "Agones")


Inconsistent formatting: The Category parameter should be formatted as Category="Agones" (without spaces around =) to match the predominant style used throughout the rest of this file (see lines 27, 30, 179, 182, 223, 226, etc.).

Suggested change

UPROPERTY(BlueprintReadOnly, Category = "Agones")

int32 Count = 0;

UPROPERTY(BlueprintReadOnly, Category = "Agones")

UPROPERTY(BlueprintReadOnly, Category="Agones")

int32 Count = 0;

UPROPERTY(BlueprintReadOnly, Category="Agones")

Copilot · 2025-11-18T01:59:17Z

sdks/unreal/Agones/Source/Agones/Classes/Classes.h

+	UPROPERTY(BlueprintReadOnly, Category = "Agones")
+	int32 Count = 0;
+
+	UPROPERTY(BlueprintReadOnly, Category = "Agones")


Inconsistent formatting: The Category parameter should be formatted as Category="Agones" (without spaces around =) to match the predominant style used throughout the rest of this file.

Suggested change

UPROPERTY(BlueprintReadOnly, Category = "Agones")

int32 Count = 0;

UPROPERTY(BlueprintReadOnly, Category = "Agones")

UPROPERTY(BlueprintReadOnly, Category="Agones")

int32 Count = 0;

UPROPERTY(BlueprintReadOnly, Category="Agones")

Copilot · 2025-11-18T01:59:17Z

sdks/unreal/Agones/Source/Agones/Classes/Classes.h

 	UPROPERTY(BlueprintReadOnly, Category="Agones")
 	TArray<FPort> Ports;

+	UPROPERTY(BlueprintReadOnly, Category = "Agones")


Inconsistent formatting: The Category parameter should be formatted as Category="Agones" (without spaces around =) to match the predominant style used throughout the rest of this file.

Suggested change

UPROPERTY(BlueprintReadOnly, Category = "Agones")

UPROPERTY(BlueprintReadOnly, Category="Agones")

Copilot · 2025-11-18T01:59:18Z

sdks/unreal/Agones/Source/Agones/Classes/Classes.h

+	int32 Count = 0;
+
+	UPROPERTY(BlueprintReadOnly, Category = "Agones")
+	int32 Capacity = 0;


Type inconsistency: FCounter uses int32 for Count and Capacity, while FCounterResponse (lines 466, 469) uses int64 for the same fields. These structures represent similar counter data and should use consistent types. Consider using int64 to match FCounterResponse and avoid potential truncation issues.

Suggested change

int32 Count = 0;

UPROPERTY(BlueprintReadOnly, Category = "Agones")

int32 Capacity = 0;

int64 Count = 0;

UPROPERTY(BlueprintReadOnly, Category = "Agones")

int64 Capacity = 0;

markmandel · 2025-11-18T02:00:51Z

Copilot is nitpicky! 😁

keith-miller

lgtm

agones-bot · 2025-11-18T02:48:23Z

Build Succeeded 🥳

Build Id: fc52eb74-046c-4011-b01b-92a4ec72d247

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-53d713d
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-53d713d
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-53d713d-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-53d713d
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-53d713d
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-53d713d
Linux C++ SDK (build): agonessdk-1.54.0-dev-53d713d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-53d713d.zip

A preview of the website (the last 30 builds are retained):

https://53d713d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4333/head:pr_4333 && git checkout pr_4333
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-53d713d

markmandel · 2025-11-18T15:45:05Z

/gcbrun

markmandel · 2025-11-18T15:49:27Z

lgtm

Thank you @keith-miller ! - if you aren't careful you'll rack up enough reviews to become an approver on Agones 😁
(completely not subtle prompting 😄 )

Copilot

Pull Request Overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sdks/unreal/Agones/Source/Agones/Classes/Classes.h

agones-bot · 2025-11-18T16:42:36Z

Build Succeeded 🥳

Build Id: ee21cb2e-99f9-48f8-8365-7241eaece51c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-336628b
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-336628b
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-336628b-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-336628b
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-336628b
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-336628b
Linux C++ SDK (build): agonessdk-1.54.0-dev-336628b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-336628b.zip

A preview of the website (the last 30 builds are retained):

https://336628b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4333/head:pr_4333 && git checkout pr_4333
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-336628b

markmandel

let's go.

igooch · 2025-11-24T21:50:02Z

/gcbrun

markmandel · 2025-11-24T22:21:30Z

/gcbrun

rofl, I forgot to run it

agones-bot · 2025-11-24T23:19:26Z

Build Succeeded 🥳

Build Id: ca726a69-81b6-40b8-93a6-6e1aa6a8b572

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-57d64b1
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-57d64b1
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-57d64b1-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-57d64b1
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-57d64b1
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-57d64b1
Linux C++ SDK (build): agonessdk-1.54.0-dev-57d64b1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-57d64b1.zip

A preview of the website (the last 30 builds are retained):

https://57d64b1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4333/head:pr_4333 && git checkout pr_4333
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-57d64b1

* add counters to status

GloryOfNight added 2 commits November 12, 2025 09:53

add counters to status

9554f6d

fix spaces to tabs

53d713d

github-actions bot added kind/feature New features for Agones size/S labels Nov 12, 2025

markmandel requested a review from Copilot November 18, 2025 01:55

Copilot started reviewing on behalf of markmandel November 18, 2025 01:56 View session

Copilot finished reviewing on behalf of markmandel November 18, 2025 01:58

Copilot AI reviewed Nov 18, 2025

View reviewed changes

keith-miller approved these changes Nov 18, 2025

View reviewed changes

apply review fixes

336628b

markmandel requested a review from Copilot November 18, 2025 15:47

Copilot started reviewing on behalf of markmandel November 18, 2025 15:48 View session

Copilot finished reviewing on behalf of markmandel November 18, 2025 15:49

Copilot AI reviewed Nov 18, 2025

View reviewed changes

sdks/unreal/Agones/Source/Agones/Classes/Classes.h Show resolved Hide resolved

markmandel approved these changes Nov 23, 2025

View reviewed changes

markmandel enabled auto-merge (squash) November 23, 2025 22:36

Merge branch 'main' into feature/add-status-counters

57d64b1

markmandel merged commit 34e1be4 into agones-dev:main Nov 24, 2025
4 checks passed

mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026

[Unreal] Add counters support to status (agones-dev#4333)

f49e258

* add counters to status

	UPROPERTY(BlueprintReadOnly, Category = "Agones")
	UPROPERTY(BlueprintReadOnly, Category="Agones")

Conversation

GloryOfNight commented Nov 12, 2025

Uh oh!

GloryOfNight commented Nov 17, 2025

Uh oh!

markmandel commented Nov 18, 2025

Uh oh!

markmandel commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

markmandel commented Nov 18, 2025

Uh oh!

keith-miller left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Nov 18, 2025

Uh oh!

markmandel commented Nov 18, 2025

Uh oh!

markmandel commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

agones-bot commented Nov 18, 2025

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

igooch commented Nov 24, 2025

Uh oh!

markmandel commented Nov 24, 2025

Uh oh!

agones-bot commented Nov 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants