Skip to content

build: upgrade MetalLB to v0.15.2 and use helm upgrade --install#4330

Merged
lacroixthomas merged 1 commit intoagones-dev:mainfrom
markmandel:cleanup/metalib
Nov 10, 2025
Merged

build: upgrade MetalLB to v0.15.2 and use helm upgrade --install#4330
lacroixthomas merged 1 commit intoagones-dev:mainfrom
markmandel:cleanup/metalib

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

  • Update MetalLB version from 0.13.12 to 0.15.2 in kind and minikube makefiles
  • Change from 'helm install' to 'helm upgrade --install' for better idempotency
  • This allows the command to work on both fresh installs and upgrades

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

- Update MetalLB version from 0.13.12 to 0.15.2 in kind and minikube makefiles
- Change from 'helm install' to 'helm upgrade --install' for better idempotency
- This allows the command to work on both fresh installs and upgrades
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Nov 10, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the MetalLB Helm chart version from 0.13.12 to 0.15.2 and switches from helm install to helm upgrade --install for idempotent deployments across both minikube and kind test clusters.

  • Upgraded MetalLB Helm chart from version 0.13.12 to 0.15.2
  • Changed deployment command from helm install to helm upgrade --install for better idempotency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
build/includes/minikube.mk Updated MetalLB installation command for minikube clusters with new version and helm upgrade pattern
build/includes/kind.mk Updated MetalLB installation command for kind clusters with new version and helm upgrade pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@markmandel markmandel requested a review from igooch November 10, 2025 04:39
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 603206ae-b8ee-4cb3-9d0f-f10d94e96561

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4330/head:pr_4330 && git checkout pr_4330
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-02cee01

Copy link
Copy Markdown
Collaborator

@lacroixthomas lacroixthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea about the helm upgrade --install !
LGTM !

@lacroixthomas lacroixthomas merged commit 7832327 into agones-dev:main Nov 10, 2025
10 checks passed
@markmandel markmandel deleted the cleanup/metalib branch November 10, 2025 21:48
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
…nes-dev#4330)

- Update MetalLB version from 0.13.12 to 0.15.2 in kind and minikube makefiles
- Change from 'helm install' to 'helm upgrade --install' for better idempotency
- This allows the command to work on both fresh installs and upgrades
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants