Fix sdkserver updatelist gameserver max items#4326
Fix sdkserver updatelist gameserver max items#4326markmandel merged 24 commits intoagones-dev:mainfrom
Conversation
|
Build Failed 😭 Build Id: 319cbd65-a372-4be5-a987-ec4147f8a048 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 9e75dbdc-79ea-4f5e-85f4-46c2cbe69e72 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: e3d85ba8-6eb9-45b8-8629-aaa00ed5917b Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Failed 😭 Build Id: 55b79fc1-6166-4dce-a2f3-671c82e76ef1 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 7e8a1900-0cef-4c8b-aeec-3f0b6c905c7e Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 3c1bf51b-6835-432b-9b0e-3370a9e3e2aa Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: b82c3e58-65be-40aa-aeff-51a8683eae02 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 94b9b58d-2871-4e76-942a-2beab4801f4f Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: e600b69e-e83c-4af2-9a6e-5b360d3c0fa0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: d288eba9-4bdd-4227-a4bd-e662e16d0cc1 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Failed 😭 Build Id: a28a2835-69ee-4c25-af49-56c246697668 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: 2b38c2db-b83c-4628-a30c-3a22180a129b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 0ad4b7d8-6d35-42ea-b28b-7514028f5378 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
| func (gs *GameServer) UpdateListCapacity(name string, capacity int64) error { | ||
| if capacity < 0 || capacity > apiserver.ListMaxCapacity { | ||
|
|
||
| if capacity < 0 || capacity > ListMaxCapacity { |
There was a problem hiding this comment.
This should not be hard-coded to 1000. The point of this PR is to use in the value of gameservers.lists.maxItems and not a hard-coded value. gameservers.lists.maxItems already defaults to 1000 if a user does not specify a value.
There was a problem hiding this comment.
Yeah Correct, but without the gameserver config the test cases run. Since gameservers.lists.maxItems is only available after fetching, it causes an error, so I used a hard-coded value.
|
Build Succeeded 🥳 Build Id: 2934421c-df24-4882-9fe9-12a3609a2188 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: ae326180-1d53-42b0-9505-1c7d5f815403 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: a79c6800-5bc8-479f-ada5-f17e08fdbc87 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 5d65dc94-9c0f-4f2a-babc-e6173f015e94 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: 57e6cd21-847a-43f9-8683-3f13a1ee51c4 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Flaky unit test: Haven't seen that one before! /gcbrun |
The hunt of flaky tests continue haha 🎄 🎁 |
|
Build Failed 😭 Build Id: baa024ca-a29e-4888-b798-a3932f47e2a3 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Failed 😭 Build Id: 147dcfeb-96f4-44b0-a859-5f058ccfc006 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Wow, we are running into a slew of flakes after having such a good run lately! /gcbrun |
|
Build Succeeded 🥳 Build Id: 97574849-e5ff-40d7-ba96-0410d9636c06 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
* fix sdkserver updatelist gameserver max items * fix lint error * update tescases updatelist * fix e2e test * changes e2e namespaces rbac * Fix e2e error * remove apiserver list max capcity in localsdk * remove apiserver listmax capacity * fix gamerserver testcases * fix lint error --------- Co-authored-by: Mark Mandel <mark@compoundtheory.com> Co-authored-by: igooch <igooch@google.com>
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #4282
Special notes for your reviewer: