Skip to content

Fix sdkserver updatelist gameserver max items#4326

Merged
markmandel merged 24 commits intoagones-dev:mainfrom
Sivasankaran25:update_sdkserver
Dec 18, 2025
Merged

Fix sdkserver updatelist gameserver max items#4326
markmandel merged 24 commits intoagones-dev:mainfrom
Sivasankaran25:update_sdkserver

Conversation

@Sivasankaran25
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4282

Special notes for your reviewer:

@Sivasankaran25 Sivasankaran25 self-assigned this Nov 7, 2025
@github-actions github-actions bot added kind/bug These are bugs. size/S labels Nov 7, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 319cbd65-a372-4be5-a987-ec4147f8a048

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 9e75dbdc-79ea-4f5e-85f4-46c2cbe69e72

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: e3d85ba8-6eb9-45b8-8629-aaa00ed5917b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Sivasankaran25
Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 55b79fc1-6166-4dce-a2f3-671c82e76ef1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 7e8a1900-0cef-4c8b-aeec-3f0b6c905c7e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 3c1bf51b-6835-432b-9b0e-3370a9e3e2aa

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the original issue #4282, remove the ListMaxCapacity. Also search in the code base for everywhere that the ListMaxCapacity is used, and replace that value with the non-hardcoded value.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: b82c3e58-65be-40aa-aeff-51a8683eae02

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 94b9b58d-2871-4e76-942a-2beab4801f4f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: e600b69e-e83c-4af2-9a6e-5b360d3c0fa0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-fab928a

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: d288eba9-4bdd-4227-a4bd-e662e16d0cc1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Sivasankaran25
Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: a28a2835-69ee-4c25-af49-56c246697668

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 2b38c2db-b83c-4628-a30c-3a22180a129b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-032d226

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 0ad4b7d8-6d35-42ea-b28b-7514028f5378

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-7b4200e

func (gs *GameServer) UpdateListCapacity(name string, capacity int64) error {
if capacity < 0 || capacity > apiserver.ListMaxCapacity {

if capacity < 0 || capacity > ListMaxCapacity {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be hard-coded to 1000. The point of this PR is to use in the value of gameservers.lists.maxItems and not a hard-coded value. gameservers.lists.maxItems already defaults to 1000 if a user does not specify a value.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Correct, but without the gameserver config the test cases run. Since gameservers.lists.maxItems is only available after fetching, it causes an error, so I used a hard-coded value.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 2934421c-df24-4882-9fe9-12a3609a2188

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-4617415

Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, LGTM.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: ae326180-1d53-42b0-9505-1c7d5f815403

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-35c12f0

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: a79c6800-5bc8-479f-ada5-f17e08fdbc87

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-c05c00a

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 5d65dc94-9c0f-4f2a-babc-e6173f015e94

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-6408714

@markmandel markmandel enabled auto-merge (squash) December 17, 2025 23:43
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 57e6cd21-847a-43f9-8683-3f13a1ee51c4

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

Flaky unit test:

{"message":"unable to calculate 'Ready' state duration of 's2v9llhh4v1' GameServer","severity":"warning","source":"*metrics.Controller","time":"2025-12-17T23:54:54.815475533Z"}
--- FAIL: TestControllerGameServerCount (2.11s)
    controller_test.go:88: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/metrics/controller_test.go:88
        	            				/go/src/agones.dev/agones/pkg/metrics/controller_test.go:289
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 1
        	Test:       	TestControllerGameServerCount
        	Messages:   	metric: gameservers_count, tags: [{none true} {default true} {PortAllocation true}], values don't match; got: 1, want: 2
{"message":"Wait for cache sync","severity":"info","time":"2025-12-17T23:54:54.818099822Z"}

Haven't seen that one before!

/gcbrun

@lacroixthomas
Copy link
Copy Markdown
Collaborator

lacroixthomas commented Dec 18, 2025

Flaky unit test:

{"message":"unable to calculate 'Ready' state duration of 's2v9llhh4v1' GameServer","severity":"warning","source":"*metrics.Controller","time":"2025-12-17T23:54:54.815475533Z"}
--- FAIL: TestControllerGameServerCount (2.11s)
    controller_test.go:88: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/metrics/controller_test.go:88
        	            				/go/src/agones.dev/agones/pkg/metrics/controller_test.go:289
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 1
        	Test:       	TestControllerGameServerCount
        	Messages:   	metric: gameservers_count, tags: [{none true} {default true} {PortAllocation true}], values don't match; got: 1, want: 2
{"message":"Wait for cache sync","severity":"info","time":"2025-12-17T23:54:54.818099822Z"}

Haven't seen that one before!

/gcbrun

The hunt of flaky tests continue haha 🎄 🎁

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: baa024ca-a29e-4888-b798-a3932f47e2a3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 147dcfeb-96f4-44b0-a859-5f058ccfc006

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

Wow, we are running into a slew of flakes after having such a good run lately!

{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.300117927Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc0005121b8), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.330178102Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc00029e918), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.336392319Z"}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.408275581Z","x":0}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.409084437Z","x":1}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.409478598Z","x":2}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.409839686Z","x":3}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.410333624Z","x":4}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.410729942Z","x":5}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.411247676Z","x":6}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.411530011Z","x":0}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.415717388Z","x":1}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.415288Z","x":0}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.416492333Z","x":1}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.416995859Z","x":2}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.417310957Z","x":3}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.417744307Z","x":4}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.411431458Z","x":0}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.418957801Z","x":1}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.419443652Z","x":2}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.419889107Z","x":3}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.420325529Z","x":4}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.420804429Z","x":5}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.421269348Z","x":6}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.421640995Z","x":7}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.422078302Z","x":8}
{"i":0,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.422516723Z","x":9}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.418246417Z","x":5}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.42303768Z","x":6}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.411300156Z","x":0}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.423889263Z","x":1}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.424282217Z","x":2}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.424672492Z","x":3}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.425049353Z","x":4}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.425367347Z","x":5}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.425954291Z","x":6}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.426276063Z","x":7}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.426734476Z","x":8}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.41610971Z","x":2}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.427811709Z","x":7}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.435927564Z","x":8}
{"i":4,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.436482305Z","x":9}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.427822515Z","x":3}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.438217961Z","x":4}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.43871888Z","x":5}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.43918493Z","x":6}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.439637512Z","x":7}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.440205056Z","x":8}
{"i":3,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.440879389Z","x":9}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.411667233Z","x":7}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.441692221Z","x":8}
{"i":1,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.442058076Z","x":9}
{"i":2,"message":"allocating!","severity":"info","time":"2025-12-18T01:53:01.427385738Z","x":9}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.446306792Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.44810997Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.449735612Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc0000128b8), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.457608936Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.449802564Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.449992501Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000274298), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.481232589Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc0004a4b48), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.482860882Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc0002743b8), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.49917692Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000512588), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.527299524Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc00029e978), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.527655611Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc0004a4cd8), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.512089058Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.555240689Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000248238), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.557567904Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.588072899Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc0002485b8), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.59032042Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.668704602Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc000248ad8), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.676177123Z"}
{"message":"Allocated Port","ports":[{"range":"default","portPolicy":"Dynamic","containerPort":7777,"hostPort":10},{"name":"another","range":"default","portPolicy":"Dynamic","containerPort":6666,"hostPort":13},{"name":"static","range":"default","portPolicy":"Static","containerPort":6666,"hostPort":9999},{"name":"passthrough","range":"default","portPolicy":"Passthrough","containerPort":15,"hostPort":15}],"severity":"info","time":"2025-12-18T01:53:01.771914864Z","uid":"0:0"}
{"message":"Allocated Port","ports":[{"range":"default","portPolicy":"Dynamic","containerPort":7777,"hostPort":11},{"name":"another","range":"default","portPolicy":"Dynamic","containerPort":6666,"hostPort":12},{"name":"static","range":"default","portPolicy":"Static","containerPort":6666,"hostPort":9999},{"name":"passthrough","range":"default","portPolicy":"Passthrough","containerPort":14,"hostPort":14}],"severity":"info","time":"2025-12-18T01:53:01.77335006Z","uid":"0:1"}
{"message":"Allocated Port","ports":[{"range":"default","portPolicy":"Dynamic","containerPort":7777,"hostPort":16},{"name":"another","range":"default","portPolicy":"Dynamic","containerPort":6666,"hostPort":17},{"name":"static","range":"default","portPolicy":"Static","containerPort":6666,"hostPort":9999},{"name":"passthrough","range":"default","portPolicy":"Passthrough","containerPort":20,"hostPort":20}],"severity":"info","time":"2025-12-18T01:53:01.773758878Z","uid":"0:2"}
{"message":"Allocated Port","ports":[{"range":"default","portPolicy":"Dynamic","containerPort":7777,"hostPort":18},{"name":"another","range":"default","portPolicy":"Dynamic","containerPort":6666,"hostPort":19},{"name":"static","range":"default","portPolicy":"Static","containerPort":6666,"hostPort":9999},{"name":"passthrough","range":"default","portPolicy":"Passthrough","containerPort":20,"hostPort":20}],"severity":"info","time":"2025-12-18T01:53:01.774106469Z","uid":"1:0"}
{"message":"Allocated Port","ports":[{"range":"default","portPolicy":"Dynamic","containerPort":7777,"hostPort":18},{"name":"another","range":"default","portPolicy":"Dynamic","containerPort":6666,"hostPort":10},{"name":"static","range":"default","portPolicy":"Static","containerPort":6666,"hostPort":9999},{"name":"passthrough","range":"default","portPolicy":"Passthrough","containerPort":11,"hostPort":11}],"severity":"info","time":"2025-12-18T01:53:01.77449422Z","uid":"1:1"}
{"message":"Allocated Port","ports":[{"range":"default","portPolicy":"Dynamic","containerPort":7777,"hostPort":12},{"name":"another","range":"default","portPolicy":"Dynamic","containerPort":6666,"hostPort":13},{"name":"static","range":"default","portPolicy":"Static","containerPort":6666,"hostPort":9999},{"name":"passthrough","range":"default","portPolicy":"Passthrough","containerPort":16,"hostPort":16}],"severity":"info","time":"2025-12-18T01:53:01.774957961Z","uid":"1:2"}
{"Allocated":18,"Total":22,"message":"Ports count","severity":"info","time":"2025-12-18T01:53:01.779535478Z"}
{"Allocated":21,"Total":22,"message":"Ports count","severity":"info","time":"2025-12-18T01:53:01.779959789Z"}
{"Allocated":24,"Total":33,"message":"Ports count","severity":"info","time":"2025-12-18T01:53:01.780365807Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.782007263Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc00029f178), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.783935436Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc00029f1f8), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.784916751Z"}
{"message":"Wait for cache sync","severity":"info","time":"2025-12-18T01:53:01.885161533Z"}
{"message":"unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}, ListOptions:v1.ListOptions{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, LabelSelector:\"\", FieldSelector:\"\", Watch:true, AllowWatchBookmarks:true, ResourceVersion:\"\", ResourceVersionMatch:\"\", TimeoutSeconds:(*int64)(0xc00029f858), Limit:0, Continue:\"\", SendInitialEvents:(*bool)(nil)}}","severity":"error","time":"2025-12-18T01:53:01.8878336Z"}
--- FAIL: TestPortRangeAllocatorSyncDeleteGameServer (1.13s)
    portallocator_test.go:603: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/portallocator/portallocator_test.go:603
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestPortRangeAllocatorSyncDeleteGameServer
FAIL
FAIL	agones.dev/agones/pkg/portallocator	2.162s

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 97574849-e5ff-40d7-ba96-0410d9636c06

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-569a0b6

@markmandel markmandel merged commit 1db6361 into agones-dev:main Dec 18, 2025
4 checks passed
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
* fix sdkserver updatelist gameserver max items

* fix lint error

* update tescases updatelist

* fix e2e test

* changes e2e namespaces rbac

* Fix e2e error

* remove apiserver list max capcity in localsdk

* remove apiserver listmax capacity

* fix gamerserver testcases

* fix lint error

---------

Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Co-authored-by: igooch <igooch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdkserver UpdateList does not respect gameservers.lists.maxItems

5 participants