Populate Env Vars for GameServer init containers#4319
Merged
markmandel merged 5 commits intoagones-dev:mainfrom Oct 31, 2025
Merged
Populate Env Vars for GameServer init containers#4319markmandel merged 5 commits intoagones-dev:mainfrom
markmandel merged 5 commits intoagones-dev:mainfrom
Conversation
markmandel
reviewed
Oct 30, 2025
Collaborator
markmandel
left a comment
There was a problem hiding this comment.
Thanks, we needed this!
/gcbrun
| func (c *Controller) addSDKServerEnvVars(gs *agonesv1.GameServer, pod *corev1.Pod) { | ||
| sdkEnvVars := sdkEnvironmentVariables(gs) | ||
| if sdkEnvVars == nil { | ||
| // If a gameserver was created before 1.1 when we started defaulting the grpc and http ports, |
Collaborator
There was a problem hiding this comment.
I wish I could remember why this is here 🤣
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
1 similar comment
Collaborator
|
/gcbrun |
Collaborator
|
Build Succeeded 🥳 Build Id: 519cc5be-20c0-4c48-ba44-b229fbda7957 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Collaborator
|
Build Failed 😭 Build Id: c189e602-98ca-445d-a1a4-ee897ee0b993 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Collaborator
|
Build Succeeded 🥳 Build Id: 95b70e62-0bca-429c-bf2e-1511167673a7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
* populate env variables for init containers * add newline * move addEnvVars function to global scope * remove newline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This MR adds code to populate environment variables for init containers defined in a
GameServerspec.This allows init containers to communicate with the SDK server during initialization, enabling use cases where setup logic needs to interact with Agones APIs before the main game server container starts.
Which issue(s) this PR fixes:
Closes #4241