Skip to content

npm audit fix#4305

Merged
igooch merged 2 commits intoagones-dev:mainfrom
igooch:npm-update
Oct 20, 2025
Merged

npm audit fix#4305
igooch merged 2 commits intoagones-dev:mainfrom
igooch:npm-update

Conversation

@igooch
Copy link
Copy Markdown
Collaborator

@igooch igooch commented Oct 20, 2025

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

When running make test there is the warning:

Run `npm audit` for details.

  npm audit fix
To address all issues, run:

3 vulnerabilities (1 low, 1 moderate, 1 high)

This code was generated by running npm audit fix in the sdks/nodejs directory.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/M labels Oct 20, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 20, 2025

Build Failed 😭

Build Id: bd8ca02f-9402-4b69-876c-0d335ec1fb47

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 20, 2025

Build Succeeded 🥳

Build Id: da76d340-efc0-4ad9-b8b3-f3d026ca595e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4305/head:pr_4305 && git checkout pr_4305
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-ef64bb2

@vicentefb
Copy link
Copy Markdown
Collaborator

vicentefb commented Oct 20, 2025

/lgtm

@vicentefb vicentefb self-requested a review October 20, 2025 17:44
@vicentefb
Copy link
Copy Markdown
Collaborator

vicentefb commented Oct 20, 2025

/approve

@igooch igooch merged commit 0020a85 into agones-dev:main Oct 20, 2025
4 checks passed
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
@igooch @mnthe
Ran npm audit fix (agones-dev#4305)
1158294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicentefb vicentefb vicentefb approved these changes

+1 more reviewer

@steven-supersolid steven-supersolid steven-supersolid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igooch @agones-bot @vicentefb @steven-supersolid