Feat: integrate processor on allocator by lacroixthomas · Pull Request #4302 · agones-dev/agones

lacroixthomas · 2025-10-07T23:18:35Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / Why we need it:

Integrate the processor client on the allocator + add new config

Which issue(s) this PR fixes:

Part of #4190

Special notes for your reviewer:

agones-bot · 2025-10-08T00:49:54Z

Build Failed 😭

Build Id: 8bf2d25e-8a25-40e8-be90-5d0f4cc67808

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-16T00:15:05Z

Build Failed 😭

Build Id: 23eb3392-ae6d-4e04-a5e5-721180541830

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-10-16T00:18:56Z

/gcbrun

Will double check later on (still got some part to do on this PR - config)

agones-bot · 2025-10-16T02:04:13Z

Build Failed 😭

Build Id: 945200ee-29f9-485a-94cd-0ef737615845

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-10-16T21:56:12Z

Step #1 - "e2e-feature-gates": VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/examples_test.go:93
Step #1 - "e2e-feature-gates": VERBOSE:         	Error:      	Received unexpected error:
Step #1 - "e2e-feature-gates": VERBOSE:         	            	waiting for {supertuxkart [{default  Dynamic <nil> 8080 0 UDP}] {false 10 0 120}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []} {[] [] [{supertuxkart us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.19 [] []  [] [] [{ENABLE_PLAYER_TRACKING false nil}] {map[] map[cpu:{{500 -3} {<nil>} 500m DecimalSI} memory:{{1073741824 0} {<nil>} 1Gi BinarySI}] []} [] <nil> [] [] nil nil nil nil    nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil <nil> [] [] nil}} <nil> map[] map[] <nil>} GameServer instance readiness timed out (): waiting for GameServer 1760580232/supertuxkart-t2dpk to be Ready: GameServer reached terminal state Unhealthy
Step #1 - "e2e-feature-gates": VERBOSE:         	Test:       	TestSuperTuxKartGameServerReady
Step #1 - "e2e-feature-gates": VERBOSE:         	Messages:   	Ready game server timed out

(getting worked on from another PR)

/gcbrun

agones-bot · 2025-10-16T23:41:34Z

Build Succeeded 🥳

Build Id: 413aabcb-7e7e-4c35-9303-008da3a2bda2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-9606991
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-9606991
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-9606991-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-9606991
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-9606991
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-9606991
Linux C++ SDK (build): agonessdk-1.53.0-dev-9606991-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-9606991.zip

A preview of the website (the last 30 builds are retained):

https://9606991-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4302/head:pr_4302 && git checkout pr_4302
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-9606991

agones-bot · 2025-10-17T01:13:25Z

Build Succeeded 🥳

Build Id: 7a9c4779-6d73-4894-a30c-047ad48dc0b4

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-6511861
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-6511861
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-6511861-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-6511861
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-6511861
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-6511861
Linux C++ SDK (build): agonessdk-1.53.0-dev-6511861-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-6511861.zip

A preview of the website (the last 30 builds are retained):

https://6511861-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4302/head:pr_4302 && git checkout pr_4302
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-6511861

markmandel · 2025-10-17T04:07:30Z

cmd/allocator/main.go

+	processorAllocationTimeout       = "processor-allocation-timeout"
+	processorReconnectInterval       = "processor-reconnect-interval"


I'm wondering if we should just hardcode processorAllocationTimeout and processorReconnectInterval to values that work best 🤔

Do we see there being value in making them configurable?

Good point, there is maybe not that much value to have it configurable, I'll hardcode it at the allocator level (and then on the extension one), If we see later on some value we can add it back to be configurable 👌🏼

agones-bot · 2025-10-19T21:35:39Z

Build Failed 😭

Build Id: 4bbed570-6bde-49ad-9e3a-90f9720ef0af

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-19T21:51:48Z

Build Failed 😭

Build Id: e2fadb55-f6e6-4ab8-93fa-36389462c74c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-19T22:45:56Z

Build Failed 😭

Build Id: ad929e2f-bcfc-445e-bda1-168afbb389b4

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-20T17:55:26Z

Build Failed 😭

Build Id: befed37d-e7c6-44f9-960a-db5d2a3d5f71

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-20T19:16:25Z

Build Succeeded 🥳

Build Id: 27d4abb2-41f4-4fef-b827-4f133526c9d8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-1430bcc
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-1430bcc
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-1430bcc-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-1430bcc
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-1430bcc
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-1430bcc
Linux C++ SDK (build): agonessdk-1.53.0-dev-1430bcc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-1430bcc.zip

A preview of the website (the last 30 builds are retained):

https://1430bcc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4302/head:pr_4302 && git checkout pr_4302
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-1430bcc

markmandel

NIce!

* feat: integrate processor on allocator * feat: update feature gates flow * feat: remove previous feature gate check * feat: rollback changes from newServiceHandler * feat: cleanup new line * feat: add config + template update * feat: remove comment * feat: update log * feat: remove processor alloc timeout and reconnect interval from config * feat: fix allocaiton template

feat: integrate processor on allocator

543d9c6

github-actions bot added kind/feature New features for Agones size/M labels Oct 7, 2025

lacroixthomas added 4 commits October 15, 2025 18:39

Merge branch 'main' into features/integrate-processor-in-allocator

7dde6f5

feat: update feature gates flow

b1cc83e

feat: remove previous feature gate check

28d2b65

feat: rollback changes from newServiceHandler

f1197b0

github-actions bot added the size/S label Oct 15, 2025

feat: cleanup new line

aa265f3

lacroixthomas added 2 commits October 16, 2025 18:28

feat: add config + template update

9606991

feat: remove comment

8e93e1c

lacroixthomas marked this pull request as ready for review October 16, 2025 23:42

lacroixthomas requested review from igooch and markmandel October 16, 2025 23:44

feat: update log

6511861

markmandel reviewed Oct 17, 2025

View reviewed changes

feat: remove processor alloc timeout and reconnect interval from config

5fc9ce5

feat: fix allocaiton template

30848e2

lacroixthomas force-pushed the features/integrate-processor-in-allocator branch from cf5dc77 to 30848e2 Compare October 19, 2025 22:38

Merge branch 'main' into features/integrate-processor-in-allocator

ed8e517

Merge branch 'main' into features/integrate-processor-in-allocator

1430bcc

markmandel approved these changes Oct 20, 2025

View reviewed changes

markmandel merged commit 8a285b4 into agones-dev:main Oct 20, 2025
4 checks passed

		processorAllocationTimeout = "processor-allocation-timeout"
		processorReconnectInterval = "processor-reconnect-interval"

Conversation

lacroixthomas commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agones-bot commented Oct 8, 2025

Uh oh!

agones-bot commented Oct 16, 2025

Uh oh!

lacroixthomas commented Oct 16, 2025

Uh oh!

agones-bot commented Oct 16, 2025

Uh oh!

lacroixthomas commented Oct 16, 2025

Uh oh!

agones-bot commented Oct 16, 2025

Uh oh!

agones-bot commented Oct 17, 2025

Uh oh!

markmandel Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

lacroixthomas Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Oct 19, 2025

Uh oh!

agones-bot commented Oct 19, 2025

Uh oh!

agones-bot commented Oct 19, 2025

Uh oh!

agones-bot commented Oct 20, 2025

Uh oh!

agones-bot commented Oct 20, 2025

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lacroixthomas commented Oct 7, 2025 •

edited

Loading