This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Build Succeeded 🥳

Build Id: d7ad11ea-1a1e-4649-84e0-80930bb9fab5

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-bf2e78d
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-bf2e78d
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-bf2e78d-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-bf2e78d
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-bf2e78d
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-bf2e78d
• Linux C++ SDK (build): agonessdk-1.53.0-dev-bf2e78d-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.53.0-dev-bf2e78d.zip

A preview of the website (the last 30 builds are retained):

• https://bf2e78d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4299/head:pr_4299 && git checkout pr_4299
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-bf2e78d

Looking great !

I'm not sure about the "limited" part, if there should also be something to prevent going over a max value ? Or we expect that they handle it from their wasm ? 🤔

(also, the joy of the vendors hehe)

Actually about the limited part, they could use another policy 👌🏼

Looking great !
I'm not sure about the "limited" part, if there should also be something to prevent going over a max value ? Or we expect that they handle it from their wasm ? 🤔
(also, the joy of the vendors hehe)

Actually about the limited part, they could use another policy 👌🏼

I think I know what you're saying -- but just to be sure. The wasm policy matches the webhook autoscaler policy, in that there's no specified maximum Agones is aware of (but there could be behind the scenes from the webhook or wasm -- that's up that implementation).

Before I merge, does this line up with your expectations and understanding?

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Build Failed 😭

Build Id: 923d9cdd-38fd-442a-b0a0-600f72abe8b7

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Looking great !
I'm not sure about the "limited" part, if there should also be something to prevent going over a max value ? Or we expect that they handle it from their wasm ? 🤔
(also, the joy of the vendors hehe)

Actually about the limited part, they could use another policy 👌🏼

I think I know what you're saying -- but just to be sure. The wasm policy matches the webhook autoscaler policy, in that there's no specified maximum Agones is aware of (but there could be behind the scenes from the webhook or wasm -- that's up that implementation).

Before I merge, does this line up with your expectations and understanding?

Yep all good 👌🏼

Huh this one again 🤔

us-docker.pkg.dev/agones-images/ci
installing current release
# if IMAGE_PULL_SECRET_FILE is specified, create the agones-system namespace and install the secret
bash -c '[[ $(helm status agones -n agones-system --output json | jq -r ".info.status") =~ (failed|pending-.*) ]] && helm uninstall agones --namespace=agones-system || true'
\
	helm upgrade --install --atomic --wait --timeout 10m --namespace=agones-system \
	--create-namespace \
	--set agones.image.tag=1.53.0-dev-af20e92,agones.image.registry="us-docker.pkg.dev/agones-images/ci" \
	--set agones.image.controller.pullPolicy="Always",agones.image.controller.pullSecret= \
	--set agones.image.extensions.pullPolicy="Always",agones.image.allocator.pullPolicy="Always" \
	--set agones.image.ping.pullPolicy="Always",agones.image.sdk.alwaysPull=true \
	--set agones.ping.http.serviceType="LoadBalancer",agones.ping.udp.serviceType="LoadBalancer" \
	--set agones.allocator.service.serviceType="LoadBalancer" \
	--set agones.controller.logLevel="debug" \
	--set agones.crds.cleanupOnDelete=true \
	--set agones.featureGates="" \
	--set agones.allocator.service.loadBalancerIP=35.190.155.91 \
	--set agones.metrics.serviceMonitor.enabled=false \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Error: UPGRADE FAILED: release agones failed, and has been rolled back due to atomic being set: could not get information about the resource: an error on the server ("Internal Server Error: \"/api/v1/namespaces/agones-system/services/agones-ping-http-service\": the server is currently unable to handle the request") has prevented the request from succeeding (get services agones-ping-http-service)
make: *** [Makefile:450: install] Error 1

Maybe there's a cluster update happening.

/gcbrun

Build Succeeded 🥳

Build Id: 941a5b53-9676-4058-8c15-dcf163a4d7e2

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-af20e92
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-af20e92
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-af20e92-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-af20e92
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-af20e92
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-af20e92
• Linux C++ SDK (build): agonessdk-1.53.0-dev-af20e92-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.53.0-dev-af20e92.zip

A preview of the website (the last 30 builds are retained):

• https://af20e92-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4299/head:pr_4299 && git checkout pr_4299
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-af20e92