Skip to content

docs: clarify FleetAutoscaler webhook response structure#4297

Merged
markmandel merged 3 commits intoagones-dev:mainfrom
markmandel:docs/webhook-fix
Oct 14, 2025
Merged

docs: clarify FleetAutoscaler webhook response structure#4297
markmandel merged 3 commits intoagones-dev:mainfrom
markmandel:docs/webhook-fix

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

@markmandel markmandel commented Oct 6, 2025

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Fix the FleetAutoscaler webhook reference to state that the webhook returns a FleetAutoscaleReview with a populated FleetAutoscaleResponse. This clarifies the expected JSON payload/response pairing for external webhook integrations.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@markmandel
docs: clarify FleetAutoscaler webhook response structure
2547f44 
Fix the FleetAutoscaler webhook reference to state that the webhook
returns a FleetAutoscaleReview with a populated FleetAutoscaleResponse.
This clarifies the expected JSON payload/response pairing for external
webhook integrations.
@github-actions github-actions bot added kind/documentation Documentation for Agones size/XS labels Oct 6, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 6, 2025

Build Succeeded 🥳

Build Id: 8b544d91-4ca8-4319-962f-e6f36a6fcbaa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4297/head:pr_4297 && git checkout pr_4297
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-2547f44

@markmandel markmandel enabled auto-merge (squash) October 13, 2025 00:18
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 13, 2025

Build Failed 😭

Build Id: abcac5d3-bcbd-4187-84c8-bf36b268f022

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator Author

markmandel commented Oct 13, 2025

Unit test seems to be flaky:

--- FAIL: TestControllerAllocator (1.04s)
    --- FAIL: TestControllerAllocator/successful_allocation (1.03s)
        controller_test.go:117: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:117
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:132
            	Error:      	Not equal: 
            	            	expected: 201
            	            	actual  : 422
            	Test:       	TestControllerAllocator/successful_allocation

Also possibly some link test issues. Will rerun to see if it's common.

========================================================================
site/index.html
  Non-OK status: 403 --- site/index.html --> https://gamefabric.com/
site/blog/2019/02/13/0.8.0-release-candidate/index.html
  Non-OK status: 404 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/GoogleCloudPlatform/agones/issues/407
site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html
  Non-OK status: 404 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/issues/407
site/blog/2019/01/08/0.7.0-latency-measuring-fleet-autoscaling-webhooks-and-metrics/index.html
  Non-OK status: 404 --- site/blog/2019/01/08/0.7.0-latency-measuring-fleet-autoscaling-webhooks-and-metrics/index.html --> https://github.com/GoogleCloudPlatform/agones/issues/334
========================================================================

@markmandel
Copy link
Copy Markdown
Collaborator Author

markmandel commented Oct 13, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 13, 2025

Build Failed 😭

Build Id: 8d7a4450-caab-48a7-aedb-367c688c6cfe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 14, 2025

Build Failed 😭

Build Id: fec0b1bb-081b-4398-bb40-6bd4f43372be

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator Author

markmandel commented Oct 14, 2025

Hmnn, hopefully Autopilot isn't messed up again. gke-autopilot-1.33: BUILD FAILURE

Release "agones" does not exist. Installing it now.
I1014 14:56:43.713612      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-controller: defaulted unspecified 'cpu' resource for containers [agones-controller] (see http://g.co/gke/autopilot-defaults)."
I1014 14:56:44.127996      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-extensions: defaulted unspecified 'cpu' resource for containers [agones-extensions] (see http://g.co/gke/autopilot-defaults)."
I1014 14:56:44.521527      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-ping: defaulted unspecified 'cpu' resource for containers [agones-ping] (see http://g.co/gke/autopilot-defaults)."
I1014 14:56:44.926884      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-allocator: defaulted unspecified 'cpu' resource for containers [agones-allocator] (see http://g.co/gke/autopilot-defaults)."
I1014 14:56:45.738910      84 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
I1014 14:56:46.118927      84 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
I1014 15:06:57.241943      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Job agones-system/agones-delete-agones-resources: defaulted unspecified 'cpu' resource for containers [pre-delete-delete-agones-resources] (see http://g.co/gke/autopilot-defaults)."
Error: release agones failed, and has been uninstalled due to atomic being set: context deadline exceeded
make: *** [Makefile:450: install] Error 1

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 14, 2025

Build Succeeded 🥳

Build Id: cc324d1d-c111-4bfd-8d2b-a8c31aaae7ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4297/head:pr_4297 && git checkout pr_4297
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-15dddc3

@markmandel markmandel merged commit cc66357 into agones-dev:main Oct 14, 2025
4 checks passed
@markmandel markmandel deleted the docs/webhook-fix branch October 14, 2025 18:14
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
@markmandel @mnthe
docs: clarify FleetAutoscaler webhook response structure (agones-dev#…
ab83466 
…4297)

Fix the FleetAutoscaler webhook reference to state that the webhook
returns a FleetAutoscaleReview with a populated FleetAutoscaleResponse.
This clarifies the expected JSON payload/response pairing for external
webhook integrations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lacroixthomas lacroixthomas lacroixthomas approved these changes

@igooch igooch Awaiting requested review from igooch

Assignees

No one assigned

Labels

kind/documentation Documentation for Agones size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markmandel @agones-bot @lacroixthomas