Skip to content

feat(autoscaling): CRDs for Wasm autoscaler policy#4281

Merged
markmandel merged 3 commits intoagones-dev:mainfrom
markmandel:feature/wasm-autoscaler-crds
Oct 5, 2025
Merged

feat(autoscaling): CRDs for Wasm autoscaler policy#4281
markmandel merged 3 commits intoagones-dev:mainfrom
markmandel:feature/wasm-autoscaler-crds

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

@markmandel markmandel commented Sep 21, 2025

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

  • CRDs for WasmPolicy, with accompanying validation functions and tests
  • Rename Go type WebhookPolicy to URLConfiguration so it makes more sens when reused across difference autoscaling needs and update codebase.

Which issue(s) this PR fixes:

Work on #4080

Special notes for your reviewer:

This doesn't break older version of Agones Go libraries who use WebhookPolicy, as the backing structure of Yaml or JSON doesn't change. It's just if they are using Agones as a library to interact with Agones they will need to rename the type on upgrade. (this is something we've done before).

@markmandel
feat(autoscaling): CRDs for Wasm autoscaler policy
46e4c80 
- CRDs for WasmPolicy, with accompanying validation functions and tests
- Rename Go type WebhookPolicy to URLConfiguration so it makes more sens
  when reused across difference autoscaling needs and update codebase.

Work on agones-dev#4080
@markmandel markmandel added the kind/feature New features for Agones label Sep 21, 2025
@github-actions github-actions bot added kind/breaking Breaking change size/M labels Sep 21, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Sep 21, 2025

Build Failed 😭

Build Id: 39550fef-0b91-4fc0-9256-2a492588f7ce

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Sep 21, 2025

Build Succeeded 🥳

Build Id: 760b41a0-a821-419f-87e2-9ab21e72b9af

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4281/head:pr_4281 && git checkout pr_4281
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-a706157

lacroixthomas
lacroixthomas approved these changes Oct 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lacroixthomas lacroixthomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Just got a question regarding your comment about the changes for the webhookPolicy to URLConfiguration, how would that be communicated on the release, is it something that needs to be added somewhere to not forget it ? 🤔

@markmandel
Copy link
Copy Markdown
Collaborator Author

markmandel commented Oct 5, 2025

LGTM !

Just got a question regarding your comment about the changes for the webhookPolicy to URLConfiguration, how would that be communicated on the release, is it something that needs to be added somewhere to not forget it ? 🤔

Because of the label kind/breaking the tooling that makes the release notes will automatically categorise it out as breaking, so it'll be included in the release notes and news.

@markmandel markmandel enabled auto-merge (squash) October 5, 2025 18:44
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 5, 2025

Build Succeeded 🥳

Build Id: 8a37a418-83c7-45ff-8ce4-cee173f78797

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4281/head:pr_4281 && git checkout pr_4281
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-3ffee13

@markmandel markmandel merged commit 71be657 into agones-dev:main Oct 5, 2025
4 checks passed
@markmandel markmandel deleted the feature/wasm-autoscaler-crds branch October 5, 2025 19:46
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
@markmandel @mnthe
feat(autoscaling): CRDs for Wasm autoscaler policy (agones-dev#4281)
2e18fbe 
* feat(autoscaling): CRDs for Wasm autoscaler policy

- CRDs for WasmPolicy, with accompanying validation functions and tests
- Rename Go type WebhookPolicy to URLConfiguration so it makes more sens
  when reused across difference autoscaling needs and update codebase.

Work on agones-dev#4080

* Update crd reference docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lacroixthomas lacroixthomas lacroixthomas approved these changes

@gongmax gongmax Awaiting requested review from gongmax

@igooch igooch Awaiting requested review from igooch

Assignees

No one assigned

Labels

kind/breaking Breaking change kind/feature New features for Agones size/L size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markmandel @agones-bot @lacroixthomas