Prepend sidecars to existing init containers#4278
Merged
lacroixthomas merged 1 commit intoagones-dev:mainfrom Sep 15, 2025
Merged
Prepend sidecars to existing init containers#4278lacroixthomas merged 1 commit intoagones-dev:mainfrom
lacroixthomas merged 1 commit intoagones-dev:mainfrom
Conversation
Replacement of agones-dev#4240 with an accompanying unit test. As stated in that issue, if you want to use other init container sidecar, they should have access to the SDK server if they want it. Closes agones-dev#4239
Collaborator
|
Build Succeeded 🥳 Build Id: d6d7a66b-4981-45e3-ae74-5d51f8cff511 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
lacroixthomas
approved these changes
Sep 15, 2025
Collaborator
|
LGTM ! |
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
Replacement of agones-dev#4240 with an accompanying unit test. As stated in that issue, if you want to use other init container sidecar, they should have access to the SDK server if they want it. Closes agones-dev#4239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Replacement of #4240 with an accompanying unit test.
As stated in that issue, if you want to use other init container sidecar, they should have access to the SDK server if they want it.
Which issue(s) this PR fixes:
Closes #4239
Special notes for your reviewer: