Skip to content

Prepend sidecars to existing init containers#4278

Merged
lacroixthomas merged 1 commit intoagones-dev:mainfrom
markmandel:bug/prepend-sidecar
Sep 15, 2025
Merged

Prepend sidecars to existing init containers#4278
lacroixthomas merged 1 commit intoagones-dev:mainfrom
markmandel:bug/prepend-sidecar

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Replacement of #4240 with an accompanying unit test.

As stated in that issue, if you want to use other init container sidecar, they should have access to the SDK server if they want it.

Which issue(s) this PR fixes:

Closes #4239

Special notes for your reviewer:

Replacement of agones-dev#4240 with an accompanying unit test.

As stated in that issue, if you want to use other init container
sidecar, they should have access to the SDK server if they want it.

Closes agones-dev#4239
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: d6d7a66b-4981-45e3-ae74-5d51f8cff511

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4278/head:pr_4278 && git checkout pr_4278
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-8ec39f9

@lacroixthomas
Copy link
Copy Markdown
Collaborator

LGTM !

@lacroixthomas lacroixthomas merged commit b1e097b into agones-dev:main Sep 15, 2025
4 checks passed
@markmandel markmandel deleted the bug/prepend-sidecar branch September 16, 2025 02:34
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
Replacement of agones-dev#4240 with an accompanying unit test.

As stated in that issue, if you want to use other init container
sidecar, they should have access to the SDK server if they want it.

Closes agones-dev#4239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug These are bugs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidecar Agones API server should be the first init container

3 participants