Skip to content

flaky: TestControllerAllocator#4269

Merged
markmandel merged 3 commits intoagones-dev:mainfrom
markmandel:flaky/TestControllerAllocator
Sep 9, 2025
Merged

flaky: TestControllerAllocator#4269
markmandel merged 3 commits intoagones-dev:mainfrom
markmandel:flaky/TestControllerAllocator

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

@markmandel markmandel commented Sep 8, 2025

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Replace assert with require in controller tests for better error handling and make it easier to determine where in the tests things are failing.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Saw some odd flakiness in #4260

@markmandel
flaky: TestControllerAllocator
5a19aba 
Replace assert with require in controller tests for better
error handling and make it easier to determine where in the tests
things are failing.
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Sep 8, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Sep 8, 2025

Build Failed 😭

Build Id: 4c8b8c8e-e5b2-4149-93d6-fe108ada6160

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator Author

markmandel commented Sep 8, 2025 

    fleetautoscaler_test.go:268: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/fleetautoscaler_test.go:268
        	Error:      	Received unexpected error:
        	            	client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline
        	Test:       	TestFleetAutoScalerRollingUpdate
time="2025-09-08 02:21:19.001" level=info msg="Checking Fleet Ready replicas" expected=3 fleet=simple-fleet-1.0l8g85 fleetStatus="{Replicas:3 ReadyReplicas:3 ReservedReplicas:0 AllocatedReplicas:0 Players:<nil> Counters:map[] Lists:map[]}" test=TestUpdateFleetReplicaAndSpec
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2aa2e50]

goroutine 561 [running]:
testing.tRunner.func1.2({0x2dfec00, 0x4734e90})
	/usr/local/go/src/testing/testing.go:1734 +0x3eb
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1737 +0x696
panic({0x2dfec00?, 0x4734e90?})
	/usr/local/go/src/runtime/panic.go:792 +0x132
k8s.io/apimachinery/pkg/util/runtime.handleCrash({0x34e2580, 0x47915c0}, {0x2dfec00, 0x4734e90}, {0x47915c0, 0x0, 0xc0005a1578?})
	/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:89 +0x134
k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0x3250bf8?})
	/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:59 +0x18c
panic({0x2dfec00?, 0x4734e90?})
	/usr/local/go/src/runtime/panic.go:792 +0x132
agones.dev/agones/test/e2e.TestFleetAutoScalerRollingUpdate.func3({0x34e26d0, 0xc000ca8850})
	/go/src/agones.dev/agones/test/e2e/fleetautoscaler_test.go:280 +0x1f0
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func1(0xc0005a1c70, {0x34e26d0, 0xc000ca8850})
	/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/wait/loop.go:53 +0x70
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext({0x34e26d0, 0xc000ca8850}, {0x34cf050, 0xc00032f420}, 0x1, 0x0, 0xc0005a1c70)
	/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/wait/loop.go:54 +0x17f
k8s.io/apimachinery/pkg/util/wait.PollUntilContextTimeout({0x34e2580, 0x47915c0}, 0x3b9aca00, 0x45d964b800, 0x1, 0xc0005a1c70)
	/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/wait/poll.go:48 +0xe5
agones.dev/agones/test/e2e.TestFleetAutoScalerRollingUpdate(0xc00049e380)
	/go/src/agones.dev/agones/test/e2e/fleetautoscaler_test.go:273 +0x1425
testing.tRunner(0xc00049e380, 0x324f740)
	/usr/local/go/src/testing/testing.go:1792 +0x226
created by testing.(*T).Run in goroutine 1
	/usr/local/go/src/testing/testing.go:1851 +0x8f3

🤔 did autopilot fall over again?

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Sep 8, 2025

Build Failed 😭

Build Id: ad16f24b-6c50-43ce-9e04-8d1518067158

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator Author

markmandel commented Sep 8, 2025

That's weird - all the services are missing from the cluster.

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Sep 8, 2025

Build Succeeded 🥳

Build Id: 914ef2a7-d583-4c72-80cf-cfab9ac01df0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4269/head:pr_4269 && git checkout pr_4269
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-9dfe1e9

@markmandel markmandel merged commit ee35634 into agones-dev:main Sep 9, 2025
4 checks passed
@markmandel markmandel deleted the flaky/TestControllerAllocator branch September 9, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lacroixthomas lacroixthomas lacroixthomas approved these changes

@igooch igooch Awaiting requested review from igooch

Assignees

No one assigned

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markmandel @agones-bot @lacroixthomas