Wasm Autoscaler: Example by markmandel · Pull Request #4260 · agones-dev/agones

markmandel · 2025-09-02T02:48:26Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Added a new WASM-based FleetAutoscaler example with supporting Go/Extism plugin code, build/test tooling, and a sample manifest.

Which issue(s) this PR fixes:

Work on #4080

Special notes for your reviewer:

To run the unit and e2e tests, this compiled plugin is needed, so submitting it first.

agones-bot · 2025-09-02T03:55:12Z

Build Succeeded 🥳

Build Id: bf5332ee-8799-4650-900b-baeca6fcad72

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-ba1dfe1
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-ba1dfe1
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-ba1dfe1-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-ba1dfe1
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-ba1dfe1
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-ba1dfe1
Linux C++ SDK (build): agonessdk-1.52.0-dev-ba1dfe1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-ba1dfe1.zip

A preview of the website (the last 30 builds are retained):

https://ba1dfe1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4260/head:pr_4260 && git checkout pr_4260
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-ba1dfe1

lacroixthomas · 2025-09-02T19:15:47Z

examples/wasmfleetautoscaler.yaml

+      function: 'scale'
+      # Config values to pass to the wasm program on startup
+      config:
+        scale_buffer: 10


It might be buffer_size instead, following your main.go 🙂

Suggested change

scale_buffer: 10

buffer_size: 10

Also good catch.

lacroixthomas

Minor changes, otherwise LGTM !

Can't wait to see it all implemented, I was thinking, maybe we could add another example (later on, in another PR), about building another wasm but from another language ? Just to show that extism will be able to run the wasm build coming from any supported languages ? It's just an idea for later, might help for the doc as well 😄

examples/wasmfleetautoscaler.yaml

examples/autoscaler-wasm/model.go

Added a new WASM-based FleetAutoscaler example with supporting Go/Extism plugin code, build/test tooling, and a sample manifest. To run the unit and e2e tests, this compiled plugin is needed, so submitting it first. Work on agones-dev#4080

markmandel

Good catches! All fixed.

examples/wasmfleetautoscaler.yaml

markmandel · 2025-09-07T19:50:19Z

examples/wasmfleetautoscaler.yaml

+      function: 'scale'
+      # Config values to pass to the wasm program on startup
+      config:
+        scale_buffer: 10


Also good catch.

examples/autoscaler-wasm/model.go

lacroixthomas

LGTM ! 👌🏼

agones-bot · 2025-09-07T21:46:46Z

Build Failed 😭

Build Id: 76cd1f50-5c5f-4c1f-9261-184d478aac40

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2025-09-07T23:11:57Z

Interesting flake:

--- FAIL: TestControllerAllocator (1.02s)
    --- FAIL: TestControllerAllocator/successful_allocation (1.02s)
        controller_test.go:116: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:116
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:131
            	Error:      	Not equal: 
            	            	expected: 201
            	            	actual  : 422
            	Test:       	TestControllerAllocator/successful_allocation
        controller_test.go:119: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:119
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:131
            	Error:      	Received unexpected error:
            	            	json: cannot unmarshal string into Go struct field GameServerAllocation.status of type v1.GameServerAllocationStatus
            	Test:       	TestControllerAllocator/successful_allocation

lacroixthomas · 2025-09-07T23:32:08Z

Interesting flake:

--- FAIL: TestControllerAllocator (1.02s)
    --- FAIL: TestControllerAllocator/successful_allocation (1.02s)
        controller_test.go:116: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:116
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:131
            	Error:      	Not equal: 
            	            	expected: 201
            	            	actual  : 422
            	Test:       	TestControllerAllocator/successful_allocation
        controller_test.go:119: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:119
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:131
            	Error:      	Received unexpected error:
            	            	json: cannot unmarshal string into Go struct field GameServerAllocation.status of type v1.GameServerAllocationStatus
            	Test:       	TestControllerAllocator/successful_allocation

It's not related to your changes, but it's strange, from a unit test as well 🤔
Probably worth creating an issue for that with the logs in it, I think It's the first time I see this error from a unit test

agones-bot · 2025-09-08T01:48:11Z

Build Succeeded 🥳

Build Id: 364239fe-8ac7-44db-8643-f31dfd8dcc7f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-567aada
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-567aada
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-567aada-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-567aada
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-567aada
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-567aada
Linux C++ SDK (build): agonessdk-1.52.0-dev-567aada-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-567aada.zip

A preview of the website (the last 30 builds are retained):

https://567aada-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4260/head:pr_4260 && git checkout pr_4260
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-567aada

markmandel requested review from igooch and lacroixthomas September 2, 2025 02:48

markmandel added kind/feature New features for Agones area/examples Examples. Usually found in the `examples` directory labels Sep 2, 2025

github-actions bot added the size/M label Sep 2, 2025

lacroixthomas reviewed Sep 2, 2025

View reviewed changes

lacroixthomas reviewed Sep 3, 2025

View reviewed changes

examples/wasmfleetautoscaler.yaml Outdated Show resolved Hide resolved

examples/autoscaler-wasm/model.go Outdated Show resolved Hide resolved

markmandel added 2 commits September 7, 2025 12:49

Wasm Autoscaler: Example

7c9b4c4

Added a new WASM-based FleetAutoscaler example with supporting Go/Extism plugin code, build/test tooling, and a sample manifest. To run the unit and e2e tests, this compiled plugin is needed, so submitting it first. Work on agones-dev#4080

Review updates.

8ee6406

markmandel force-pushed the examples/wasm-examples branch from ba1dfe1 to 8ee6406 Compare September 7, 2025 19:52

markmandel commented Sep 7, 2025

View reviewed changes

lacroixthomas approved these changes Sep 7, 2025

View reviewed changes

Merge branch 'main' into examples/wasm-examples

1803e31

Merge branch 'main' into examples/wasm-examples

567aada

lacroixthomas enabled auto-merge (squash) September 7, 2025 22:47

markmandel mentioned this pull request Sep 8, 2025

flaky: TestControllerAllocator #4269

Merged

lacroixthomas merged commit 5ec619b into agones-dev:main Sep 8, 2025
4 checks passed

markmandel deleted the examples/wasm-examples branch September 10, 2025 17:16

Conversation

markmandel commented Sep 2, 2025

Uh oh!

agones-bot commented Sep 2, 2025

Uh oh!

lacroixthomas Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

markmandel Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

lacroixthomas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

markmandel Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lacroixthomas left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Sep 7, 2025

Uh oh!

markmandel commented Sep 7, 2025

Uh oh!

lacroixthomas commented Sep 7, 2025

Uh oh!

agones-bot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants