While doing the feature, I tried to understand this.

ErrConflictInGameServerSelection seems similar to the new ErrGameServerUpdateConflict but it is used when removing an already removed server from the cache, here. Maybe it is code that should have been cleaned up because I don't see a way to double remove. Also it is strange to translate that into contention.

/gcbrun

Build Succeeded 🥳

Build Id: cb4ade0a-1fbf-44db-82eb-f9c8f3740bcd

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-0fe9b1c
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-0fe9b1c
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-0fe9b1c-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-0fe9b1c
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-0fe9b1c
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-0fe9b1c
• Linux C++ SDK (build): agonessdk-1.54.0-dev-0fe9b1c-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.54.0-dev-0fe9b1c.zip

A preview of the website (the last 30 builds are retained):

• https://0fe9b1c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4267/head:pr_4267 && git checkout pr_4267
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-0fe9b1c

/gcbrun

Build Succeeded 🥳

Build Id: 74337f55-5dbd-40fe-9b99-66d6ddd67482

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-846793b
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-846793b
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-846793b-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-846793b
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-846793b
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-846793b
• Linux C++ SDK (build): agonessdk-1.54.0-dev-846793b-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.54.0-dev-846793b.zip

A preview of the website (the last 30 builds are retained):

• https://846793b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4267/head:pr_4267 && git checkout pr_4267
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-846793b