Skip to content

Fix: Add missing permission for helm uninstall in upgrade test cleanup#4250

Merged
markmandel merged 2 commits intoagones-dev:mainfrom
lacroixthomas:bugfixes/add-missing-permissions-on-upgrade-test
Aug 18, 2025
Merged

Fix: Add missing permission for helm uninstall in upgrade test cleanup#4250
markmandel merged 2 commits intoagones-dev:mainfrom
lacroixthomas:bugfixes/add-missing-permissions-on-upgrade-test

Conversation

@lacroixthomas
Copy link
Copy Markdown
Collaborator

@lacroixthomas lacroixthomas commented Aug 17, 2025

What type of PR is this?
/kind bug

What this PR does / Why we need it:

Add missing cluster role to be able to uninstall helm release for the cleanup part of the Step 25: submit-upgrade-test-cloud-build

Add missing "watch" cluster role permission for the helm uninstall --wait to be able to watch and ensure the resources is deleted properly

https://console.cloud.google.com/logs/query;cursorTimestamp=2025-08-15T18:12:05.181709256Z;endTime=2025-08-15T18:12:12.289Z;query=resource.labels.container_name%3D%22upgrade-test-controller%22%0Atimestamp%3D%222025-08-15T18:12:05.181709256Z%22%0AinsertId%3D%22s56t9kez37stp8d6%22;startTime=2025-08-15T18:11:53.327Z?project=agones-images&inv=1&invt=Ab5kLQ

Which issue(s) this PR fixes:

Closes #4249

Special notes for your reviewer:
Will trigger the pipeline a bunch of time to check the flakiness

@github-actions github-actions bot added kind/bug These are bugs. size/S labels Aug 17, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Aug 18, 2025

Build Succeeded 🥳

Build Id: 3b43e801-2bab-48a4-91db-f2f63d36b6e4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4250/head:pr_4250 && git checkout pr_4250
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-bff4ec8

@lacroixthomas lacroixthomas marked this pull request as ready for review August 18, 2025 00:24
@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

lacroixthomas commented Aug 18, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Aug 18, 2025

Build Succeeded 🥳

Build Id: 915959d7-8a2d-4f08-9c89-408108f946f6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4250/head:pr_4250 && git checkout pr_4250
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-bff4ec8

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

lacroixthomas commented Aug 18, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Aug 18, 2025

Build Succeeded 🥳

Build Id: 0a4382c0-50cf-4ce6-a502-638820720d64

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4250/head:pr_4250 && git checkout pr_4250
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-bff4ec8

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

lacroixthomas commented Aug 18, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Aug 18, 2025

Build Succeeded 🥳

Build Id: 5c8e3fe4-f724-4d64-a2c2-30fc5790ebd9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4250/head:pr_4250 && git checkout pr_4250
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-bff4ec8

@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Aug 18, 2025

OMG DID YOU FIX IT????

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

lacroixthomas commented Aug 18, 2025

I'm not sur it fixes it all, but so far so good, no issue with it, was already testing the fix on another PR last week and was working well with: #4247
My hopes are high with this one 😄

I think the missing permission on the helm uninstall was only failing sometimes on the latest version of the autopilot k8s version because it might be more "strict" around it, which could explains why it was not failing on previous version, that's wild guess though

markmandel
markmandel approved these changes Aug 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very legit. Well found!

@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Aug 18, 2025

Running one more time for giggles. Don't see any reason why we can't merge this -- at the very least, it's an issue.

/gcbrun

@markmandel markmandel enabled auto-merge (squash) August 18, 2025 15:35
@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Aug 18, 2025

Enabling auto merge - if it passes again, let's get it in!

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

lacroixthomas commented Aug 18, 2025

Running one more time for giggles. Don't see any reason why we can't merge this -- at the very least, it's an issue.

/gcbrun

I've been doing that a couple of time as well, in this PR and another one where I started debugging it, as it's a flaky test, it's always a bit stresfull but also pretty satisfying when it passes all the time 😄

igooch
igooch approved these changes Aug 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Aug 18, 2025

Build Succeeded 🥳

Build Id: d96b9417-7c84-44e0-bcac-a026ebe8a10a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4250/head:pr_4250 && git checkout pr_4250
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-bff4ec8

@markmandel markmandel merged commit c355028 into agones-dev:main Aug 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmandel markmandel markmandel approved these changes

@igooch igooch igooch approved these changes

@0xaravindh 0xaravindh Awaiting requested review from 0xaravindh

Assignees

No one assigned

Labels

kind/bug These are bugs. size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pipeline]: Missing clusterRole for Step 25 submit-upgrade-test-cloud-build

4 participants

@lacroixthomas @agones-bot @markmandel @igooch