Feat: implement rust sdk (counter and list)#4247
Feat: implement rust sdk (counter and list)#4247markmandel merged 18 commits intoagones-dev:mainfrom
Conversation
|
@Jake-Shadle @MiniaczQ |
|
Build Failed 😭 Build Id: 22c397bf-174e-441e-8a13-c04c1bf43021 Status: TIMEOUT To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: a6f71218-b5cc-4b89-9130-fdd23b6c44aa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: a6b6abc8-f2e4-42e8-85a0-840d7b4b61e3 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 1a429709-cec1-48c4-b8f8-b63c20b85c5b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 8620f7b4-b29a-4871-aaf2-42c7a2497ea3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
/gcbrun |
|
Build Failed 😭 Build Id: b77f2050-fce7-4757-82d5-1f1783dba06b Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Gonna double check the logs in GCP, but might be the issue fixed by this PR: #4224 /gcbrun |
|
Build Failed 😭 Build Id: fefdd5ad-177b-4c5e-ac06-15a86ffe2410 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: ecf81ab0-ed5b-476d-92f8-e1b01482e12a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
/gcbrun |
|
Build Failed 😭 Build Id: 61f96e87-14d9-4932-b6c7-055b0f1627a8 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
And now the unit tests are failing on metrics randomely 😭 /gcbrun |
|
Build Succeeded 🥳 Build Id: 4a16bd5f-da93-47fd-a555-51ca7dd672e6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: 1403ae8d-b6fc-4c9d-b201-e7498e4720a1 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 229320ac-a5c9-48f8-b23e-4cca5f312405 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: a9f03fe8-6177-4939-a0f7-029c663994c2 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: bb2932d9-463a-4d61-a1e0-e84c2b93d9ad Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 7679e8c2-2a2f-426e-a305-9b7f1443ef0f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
markmandel
left a comment
There was a problem hiding this comment.
This looks great! Only thing I would add is that we need to update https://agones.dev/site/docs/guides/client-sdks/rust/ (and don't forget to feature code the new pieces)
|
|
||
| // MockAlpha simulates Alpha's async methods for unit testing | ||
| struct MockAlpha { | ||
| capacity: i64, |
There was a problem hiding this comment.
This is player tracking yeah? We don't have to remove it, but it'll eventually be deleted.
There was a problem hiding this comment.
Yep, it's for the payer tracking
|
Build Succeeded 🥳 Build Id: 5468fd97-7d20-4103-9486-0dbd23b27daa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: 2fcdaaaa-f1de-4fee-aa4a-a9ee15eba4c5 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
|
/gcbrun |
|
Build Failed 😭 Build Id: e605996e-f5ec-4a64-8e10-888080f02c25 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Failed 😭 Build Id: f1fb2721-3596-45f8-bbc0-4bfa3f29dccb Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Looks like the link to Terraform hates us now. May need to escape checking it. |
|
Build Succeeded 🥳 Build Id: 27fea6d5-0f88-4da3-a76d-6cbdec5a1414 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 0facb7ad-57f0-499a-8a22-d7d1ca158931 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3644
Special notes for your reviewer:
I'm new to rust, this will need a proper review 😄